<br><br><div class="gmail_quote">On Sun, Apr 17, 2011 at 12:34 AM, Igor Stasenko <span dir="ltr"><<a href="mailto:siguctua@gmail.com">siguctua@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
On 17 April 2011 00:16, Mariano Martinez Peck <<a href="mailto:marianopeck@gmail.com">marianopeck@gmail.com</a>> wrote:<br>
><br>
> Hi Igor. I was debugging a little the CMake generation and there are 2 things I don't understand:<br>
><br>
> 1) Why you always use a "Cross" VMMaker instead of the specific OS ? I mean, in #prepareVMMaker you do:<br>
> maker := VMMaker forPlatform: 'Cross'.<br>
> Shouldn't you put the correct OS ? what are the differences doing so ? was the functionality of those special classes like Win32VMMaker, UnixVMMaker, etc.. moved the CMakeVMMaker confs ?<br>
><br>
<br>
</div>Thanks to Eliot, generated sources are not differ from one to another<br>
platform, therefore Cross is ok. :)<br>
<div class="im"><br></div></blockquote><div><br>Ok, I will add such comment to the code.<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">
<br>
> 2) Why you see all plugins as external to VMMaker ? In #prepareVMMaker you do:<br>
><br>
> allPlugins := self internalPlugins , self externalPlugins.<br>
><br>
> maker externalModules addAll: allPlugins.<br>
><br>
<br>
</div>This is to specify which plugins sources to generate.<br>
The sources output are not different whether plugin will be external<br>
or not, therefore i just adding them to single list.<br>
<div class="im"><br></div></blockquote><div><br>But since when it is not different? Again, thanks to Eliot ?<br>I mean, there should be a reason why there were 2 instVar, one for internal and anotehr one for external. In fact, when I used VMMakerTool you need to define for each plugin how to compile it. <br>
This is why I don't understand why you now say it is the same. <br>I do understand that the sources generation is the same, wether they are internal or external. BUT, why VMMaker needed to know whether they were internal or external then ? and why we don't need it anymore ?<br>
<br><br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im">
><br>
> I think this deserves a comment because it sounds pretty weird from a newbie sight.<br>
><br>
<br>
</div>I think a CodeGenerator deserves a bit of cleanup to reflect the<br>
changes described above.<br>
And since Cog VMs are not using GUI for generating sources, things<br>
like VMMakerTool can rest in peace.<br>
Personally i found it much simpler to control internal/external<br>
plugins using CMakeVMMaker classes,<br>
comparing to old ways, when you had to manually add all plugins using GUI tool.<br>
Especially, when some plugins are fit only for specific target (like<br>
ThreadedFFIPlugin),<br>
or only for specific OS, like MacMenuBarPlugin.<br></blockquote><div><br>Yes, exactly. +100. If you read my blog post, that's exactly my opinion. <br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><div></div><div class="h5"><br>
> Thanks in advance,<br>
><br>
> --<br>
> Mariano<br>
> <a href="http://marianopeck.wordpress.com" target="_blank">http://marianopeck.wordpress.com</a><br>
><br>
<br>
</div></div><font color="#888888">--<br>
Best regards,<br>
Igor Stasenko AKA sig.<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Mariano<br><a href="http://marianopeck.wordpress.com" target="_blank">http://marianopeck.wordpress.com</a><br><br>