Hi guys. I've just commited. I didn't update yet the class comments because maybe they change again...so I will wait. <br>For me what was more important is to be uniform with the pattern, and that is done now and it is nice. Regarding the prefix VM and the suffix Config, I don't have a strong thought. For me, the most information the better. First, because we have OCompletion ;) and second because you almost never type these classes. THe maximum you do is MyConf generateWithSources.<br>
<br>Anyway, I would appreciate if you can take a look and tell me. For the moment I let the suffix Config and I removed the "VM". For Cog and CogMT they look ok. With Stack they look awkward, but ok, I can live with that.<br>
<br>Thanks<br><br>Mariano<br><br><br>Name: CMakeVMMaker-MarianoMartinezPeck.96<br>Author: MarianoMartinezPeck<br>Time: 23 April 2011, 1:36:10 pm<br>UUID: 86ebc45f-3439-4be2-9ac3-5c975eab2b05<br>Ancestors: CMakeVMMaker-MarianoMartinezPeck.94<br>
<br>IMPORTANT: this commit renames ALL configurations. So, Hudson confs must be updated.<br><br>- All confs classes were renamed with the following pattern: <VM>-<OS>-[Debug-]<SpecialOptions?> (without the '-')<br>
<br>- Unix confs were moved to 'CMakeVMMaker-Unix' instead of 'CMakeVMMaker-Unix-Cog'. <br><br>- FreeBSD was moved to 'CMakeVMMaker-FreeBSD' instead of 'CMakeVMMaker-FreeBSD-Cog'<br><br>- Integrated with CMakeVMMaker-EstebanLorenzano.96<br>
<br><div class="gmail_quote">On Sat, Apr 23, 2011 at 9:16 AM, stephane ducasse <span dir="ltr"><<a href="mailto:stephane.ducasse@gmail.com">stephane.ducasse@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
keep config this is important in the name.<br>
<div><div></div><div class="h5"><br>
On Apr 22, 2011, at 11:29 PM, Mariano Martinez Peck wrote:<br>
<br>
> There are some confs that look a little ugly without the VM prefix. For example, StackUnixConfig<br>
> it sounds like a conf for a unix stack hehehehe<br>
><br>
> I am not convinced about removing the VM prefix...but ok, you all agree so.. ;)<br>
><br>
> On Fri, Apr 22, 2011 at 11:08 PM, Mariano Martinez Peck <<a href="mailto:marianopeck@gmail.com">marianopeck@gmail.com</a>> wrote:<br>
> Now...you suggested to remove the prefix VM....and what about the suffix Config ? should we keep them or remove it ?<br>
><br>
><br>
> On Fri, Apr 22, 2011 at 10:43 PM, Mariano Martinez Peck <<a href="mailto:marianopeck@gmail.com">marianopeck@gmail.com</a>> wrote:<br>
><br>
><br>
> On Fri, Apr 22, 2011 at 10:41 PM, Igor Stasenko <<a href="mailto:siguctua@gmail.com">siguctua@gmail.com</a>> wrote:<br>
><br>
> On 22 April 2011 21:38, Mariano Martinez Peck <<a href="mailto:marianopeck@gmail.com">marianopeck@gmail.com</a>> wrote:<br>
> ><br>
> ><br>
> ><br>
> > On Thu, Apr 28, 2011 at 8:34 PM, Jeremy Kajikawa <<a href="mailto:jeremy.kajikawa@gmail.com">jeremy.kajikawa@gmail.com</a>> wrote:<br>
> >><br>
> >> Do you need to put "VM" into ALL of the config strings?<br>
> >><br>
> ><br>
> > Good point. I don't know. Maybe we don't need it.<br>
> ><br>
> >><br>
> >> How about ...<br>
> >> <Machine>-<OS>-[Debug-]<SpecialOptions?><br>
> >><br>
> ><br>
> > I like it :)<br>
> ><br>
> >><br>
> >> With examples like the following...<br>
> >><br>
> >> Cog-Windows<br>
> >> Cog-Windows-Debug<br>
> >> CogMT-Windows<br>
> >> CogMT-Windows-Debug<br>
> >> CogMT-Unix<br>
> >> CogMT-Unix-NoGL<br>
> >> CogMT-Unix-Debug-NoGL<br>
> >> Stack-Windows<br>
> >> Stack-Windows-Debug<br>
> >> Stack-Windows-Debug-FixedVerSI<br>
> >> Stack-Unix<br>
> >> Stack-Unix-Debug<br>
> >> Stack-Unix-Debug-FixedVerSI<br>
> >><br>
> You cannot use '-' in class name.<br>
> However we can use underline.<br>
><br>
><br>
> Sorry, I didn't plant to use '-' it was just to make it clear for the email.<br>
><br>
><br>
> CogMT_Unix_Debug_NoGL<br>
><br>
> but then i think<br>
><br>
> CogMTUnixDebugNoGL<br>
><br>
><br>
> Exaclty, like that.<br>
><br>
><br>
> will be better.<br>
><br>
> >> Are these usable and readable by everyone?<br>
> >><br>
> >><br>
> ><br>
> ><br>
> > I like this last change. For the prefix without the "VM" I am not sure. I don't have a strong position.<br>
> > I would go with this one.<br>
><br>
> Yeah. VM can be omitted.<br>
><br>
><br>
> Excellent.<br>
><br>
> ><br>
> > Igor ? Esteban? (since you are the guys that mostly maintain them)<br>
> ><br>
><br>
> I am fine with it.<br>
> As to me, as long as things work i don't care much about naming. This<br>
> stuff is not used too often and by many..<br>
><br>
> But it will !!! As long as we start to document and improve the infrastructure new people will arrive to the VM world. At least that's what I am trying to do since the last months.<br>
><br>
> But i agree that consistent naming is good to have, so if you have a<br>
> time to spend on polishing this, do it :)<br>
><br>
><br>
> Ok, I will...we have long weekend ;)<br>
> Then you update the Hudson confs hehehe<br>
><br>
><br>
> --<br>
><br>
> Best regards,<br>
> Igor Stasenko AKA sig.<br>
><br>
><br>
><br>
> --<br>
> Mariano<br>
> <a href="http://marianopeck.wordpress.com" target="_blank">http://marianopeck.wordpress.com</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Mariano<br>
> <a href="http://marianopeck.wordpress.com" target="_blank">http://marianopeck.wordpress.com</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Mariano<br>
> <a href="http://marianopeck.wordpress.com" target="_blank">http://marianopeck.wordpress.com</a><br>
><br>
<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Mariano<br><a href="http://marianopeck.wordpress.com" target="_blank">http://marianopeck.wordpress.com</a><br><br>