<br><br><div class="gmail_quote">On Tue, Jul 5, 2011 at 2:16 AM, Bert Freudenberg <span dir="ltr"><<a href="mailto:bert@freudenbergs.de">bert@freudenbergs.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
<br>
On 05.07.2011, at 03:44, <a href="mailto:commits@squeakvm.org">commits@squeakvm.org</a> wrote:<br>
<br>
><br>
> Author: eliot<br>
> Date: 2011-07-04 18:44:47 -0700 (Mon, 04 Jul 2011)<br>
> New Revision: 2441<br>
><br>
> Modified:<br>
> trunk/platforms/Cross/plugins/IA32ABI/dabusiness.h<br>
> Log:<br>
> Get two loops in ALien marshalling consistent (albeit completely wrong).<br>
<br>
Are you applying for the obfuscated-snippet-of-the-week award? ;)<br></blockquote><div><br></div><div><blush>As unwitting winner many times before there's little point in my reapplying :( But I hope I've finally got it right in r2442...</blush> :)</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
> Modified: trunk/platforms/Cross/plugins/IA32ABI/dabusiness.h<br>
> ===================================================================<br>
> --- trunk/platforms/Cross/plugins/IA32ABI/dabusiness.h 2011-07-05 01:44:26 UTC (rev 2440)<br>
> +++ trunk/platforms/Cross/plugins/IA32ABI/dabusiness.h 2011-07-05 01:44:47 UTC (rev 2441)<br>
> @@ -18,7 +18,7 @@<br>
><br>
> #if STACKVM /* Need to access args downwards from first arg */<br>
> if (numArgs < 0)<br>
> - for (i = size = 0; --i > numArgs;) {<br>
> + for (i = size = 0; --i >= numArgs;) {<br>
> sqInt arg = argVector[i];<br>
> if (objIsAlien(arg) && sizeField(arg))<br>
> size += moduloPOT(sizeof(long),abs(sizeField(arg)));<br>
> @@ -57,7 +57,7 @@<br>
><br>
> #if STACKVM /* Need to access args downwards from first arg */<br>
> if (numArgs < 0)<br>
> - for (i = size = 0; --i > numArgs;) {<br>
> + for (i = size = 0; --i >= numArgs;) {<br>
> sqInt arg = argVector[i];<br>
> if (isSmallInt(arg)) {<br>
> *(long *)argvec = intVal(arg);<br>
><br>
<font color="#888888"><br>
- Bert -<br>
<br>
<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>best,<div>Eliot</div><br>