Haha! :)<br><br>You won me :). I was about to reply this:<br><br>"Ok, so I talked with Esteban today :). And thanks to him I reached the conclussion that this plugin should be external."<br><br>I'll spend some hours tomorrow to finish it.<br>
<br>Now, as I think it happens with the ssl plugin... Where should we put the code and what should I in order to get it easily integrated in the ci buildings? :)<br><br>Thanks!<br>Guille<br><br><div class="gmail_quote">On Sun, Apr 8, 2012 at 9:46 PM, Igor Stasenko <span dir="ltr"><<a href="mailto:siguctua@gmail.com">siguctua@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 7 April 2012 17:55, Guillermo Polito <<a href="mailto:guillermopolito@gmail.com">guillermopolito@gmail.com</a>> wrote:<br>
> Was playing in my weekend on the InternetConfigPlugin for ubuntu. And<br>
> that's the problem :), It uses gnome2 stuff to access the system<br>
> configuration (because gnome handles it's own configuration... :/).<br>
><br>
> Now, I made it work doing something like this in vmmaker:<br>
><br>
> CogFamilyUnixConfig>>configureInternetConfigPlugin: maker<br>
> "extra rules for InternetConfigPlugin"<br>
><br>
> super configureInternetConfigPlugin: maker.<br>
> maker addDefinitions: '`pkg-config --libs --cflags gtk+-2.0 gconf-2.0`'.<br>
> maker addExternalLibrary: '/usr/lib/libgconf-2.so.4'.<br>
> maker addPlatformSources: #( 'sqUnixInternetConfiguration.c').<br>
><br>
> And adding it in the list of internal plugins for Unix.<br>
><br>
> But this should only compile and work on a system with gconf and stuff<br>
> installed :).<br>
><br>
</div>Then don't make this plugin internal, but external instead. Because if<br>
library is missing,<br>
VM will refuse to start. In contrast, if your plugin will be in<br>
external module, then module will refuse to load<br>
if lib is missing.<br>
<div class="im"><br>
> So, how does or should vmmaker and vm building process handle something like<br>
> this?<br>
><br>
<br>
</div>The philosophy of CMake configurations is to be concrete and without<br>
conditionals. I.E. they should<br>
not contain "if this, do this, if that do that" , instead if you have<br>
such choice, one should make another configuration.<br>
<br>
There is no way to predict how different is platform on which you<br>
building VM from platform where it used (especially in case of unix<br>
systems and their numerous flavors). So, what is working on your OS,<br>
could not work on another. That's why i don't see a point to put<br>
conditionals in build process.<br>
<br>
In contrast, if you have a concrete configuration, which says: if you<br>
want to build me, you should have this, this and this, and if you want<br>
to use the built artifact you should have this, this and this<br>
installed, then it makes things much more predictable and<br>
straightforward.<br>
<br>
<br>
> Guille<br>
><br>
> _______________________________________________<br>
> VM-beginners mailing list<br>
> <a href="mailto:VM-beginners@lists.squeakfoundation.org">VM-beginners@lists.squeakfoundation.org</a><br>
> <a href="http://lists.squeakfoundation.org/mailman/listinfo/vm-beginners" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/vm-beginners</a><br>
><br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Best regards,<br>
Igor Stasenko.<br>
</font></span></blockquote></div><br>