<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Dec 21, 2012 at 4:24 PM, Igor Stasenko <span dir="ltr"><<a href="mailto:siguctua@gmail.com" target="_blank">siguctua@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><br>
On 21 December 2012 22:09, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com">eliot.miranda@gmail.com</a>> wrote:<br>
><br>
> Igor,<br>
><br>
> quite so. Perhaps I'll have time to change this soon. SHouldn't be hard. The test is straight-forward. if after the change the system spits out unchanged source it is working :)<br>
><br>
</div>I can do it. Because i have a lot of pressure from Pharo team to fix VM...<br>
i don't want to rollback last commit which broken our builds but<br>
instead fix that stuff.<br>
<br>
I will create a separate .cs so that you can easily merge it with your branch.<br></blockquote><div><br></div><div>thanks!! Happy Holidays...</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im HOEnZb"><br>
><br>
> On Wed, Dec 19, 2012 at 7:12 PM, Igor Stasenko <<a href="mailto:siguctua@gmail.com">siguctua@gmail.com</a>> wrote:<br>
>><br>
>><br>
>> yeah.. just looked again at #buildCodeGeneratorForCogit: getAPIMethods<br>
>><br>
>><br>
>> cogitClasses := OrderedCollection new.<br>
>> [cogitClasses addFirst: cogitClass.<br>
>> cogitClass ~~ Cogit<br>
>> and: [cogitClass inheritsFrom: Cogit]] whileTrue:<br>
>> [cogitClass := cogitClass superclass].<br>
>> cogitClasses addFirst: VMClass.<br>
>> cogitClasses addAllLast: self cogitClass ancilliaryClasses.<br>
>> cogitClasses do: [:cgc| cg addClass: cgc].<br>
>> (cg structClassesForTranslationClasses: cogitClasses) do:<br>
>> [:structClass| cg addStructClass: structClass].<br>
>><br>
>> see what wrong there?<br>
>><br>
>> it letting vmmaker to decide for a class what to do, instead letting<br>
>> class to decide for itself.<br>
>> This logic is clearly do not belongs to right place.<br>
><br>
><br>
><br>
><br>
> --<br>
> best,<br>
> Eliot<br>
><br>
<br>
<br>
<br>
</div><div class="HOEnZb"><div class="h5">--<br>
Best regards,<br>
Igor Stasenko.<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div>
</div></div>