<br><br><div class="gmail_quote">On Tue, Mar 12, 2013 at 3:03 PM, David T. Lewis <span dir="ltr"><<a href="mailto:lewis@mail.msen.com" target="_blank">lewis@mail.msen.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
On Tue, Mar 12, 2013 at 04:45:40PM -0400, David T. Lewis wrote:<br>
> On Tue, Mar 12, 2013 at 11:25:23AM -0700, Eliot Miranda wrote:<br>
> ><br>
> > On Tue, Mar 12, 2013 at 11:04 AM, Nicolas Cellier <<br>
> > <a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>> wrote:<br>
> ><br>
> > ><br>
> > > 2013/3/12 Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>>:<br>
> > > > 2013/3/12 Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com">eliot.miranda@gmail.com</a>>:<br>
> > > >><br>
> > > >> Hi Dave,<br>
> > > >><br>
> > > >> thanks, but...<br>
> > > >><br>
> > > >> On Sat, Mar 9, 2013 at 7:06 AM, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
> > > >>><br>
> > > >>><br>
> > > >>> Item was changed:<br>
> > > >>> ----- Method: VMMaker class>>versionString (in category 'version<br>
> > > testing') -----<br>
> > > >>> versionString<br>
> > > >>><br>
> > > >>> "VMMaker versionString"<br>
> > > >>><br>
> > > >>> + ^'4.10.13'!<br>
> > > >>> - ^'4.10.12'!<br>
> > > >><br>
> > > >><br>
> > > >> I *hate* the above. It is busy work (it must be done manually before<br>
> > > each commit). It is really easy to forget to do. It is meaningless<br>
> > > (because it is easy to forget it makes no guarantee that it identifies a<br>
> > > unique version). It is not a good search key. Mapping the version number<br>
> > > into the software configuration that produced the C code is hard (you have<br>
> > > to trawl through Monticello packages searching for the version with the<br>
> > > relevant version string; you can script this but fer christ's sake...).<br>
> > > >><br>
> > > >> Using the Monticello package name and version (with the dirty marker)<br>
> > > on the other hand is automatic, is a really good key, and is meaningful.<br>
> > > So please can we discard VMMaker versionString and move to using the<br>
> > > Monticello package? Please? Please.<br>
> > > >> --<br>
> > > >> best,<br>
> > > >> Eliot<br>
> > > >><br>
> > > ><br>
> > > > +1, the two requirements are<br>
> > > > - automatic<br>
> > > > - meaningful<br>
> > ><br>
><br>
> The primary requirement is that it needs to work with Ian's cmake build<br>
> procedure in trunk, such that the build automatically creates a name for<br>
> the installation subdirectory, and such that the name corresponds to what<br>
> you see when you do "squeak -version".<br>
><br>
><br>
> > > However, there is also a dependency on external source (platform...),<br>
> > > and I think it is also included in COG id no?<br>
> > ><br>
> ><br>
> > Yes. To mark the generated sources, the Cog VMMaker does this:<br>
> ><br>
> > For each source file generated, the Cog CCodeGenerator adds a comment<br>
> > containing the Smalltalk class and its VMMaker version that is translated<br>
> > to C and the Slang class and its version, e.g. from src/vm/gcc3x-cointerp,c:<br>
> ><br>
> > /* Automatically generated by<br>
> > CCodeGeneratorGlobalStructure VMMaker.oscog-eem.272 uuid:<br>
> > 8f4167f2-5bf0-4d90-9b7f-5355c741c68f<br>
> > from<br>
> > CoInterpreter VMMaker.oscog-eem.272 uuid:<br>
> > 8f4167f2-5bf0-4d90-9b7f-5355c741c68f<br>
> > */<br>
> ><br>
><br>
> This is a very good and useful thing, but unrelated to the intended use<br>
> of the version string.<br>
><br>
<br>
</div></div>... but perhaps I am just misunderstanding what you are saying. Are you<br>
suggesting that we come up with some way to generate a version string<br>
automatically based on the Monticello file name, such as '272' in the<br>
example above?<br></blockquote><div><br></div><div>I'm saying that a version needs to reflect commits and be updated automatically. That happens with the Cog/Pharo branch. The VMMaker class>>versionString approach is brittle and uninformative. I think we need to discard it and use the Cog approach which, as mentioned earlier, is a better index and is automatically updated. Yes, there;s work to update the squeak trunk build, but that's porting, not new work. It's been done both for CMake by the Pharo folks and for Cog by me. </div>
<div>But I can see this isn't going to go anywhere unless someone finds the time. So excuse the noise :)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
confused,<br>
Dave<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
> I'm sure there are better ways to generate the version string, but it's<br>
> not something that I'm working on. Meanwhile, no we cannot discard the<br>
> versionString, and I'm happy to do the updates if other folks forget to<br>
> do so.<br>
><br>
> Dave<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div>