<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<font face="Georgia">Looks a bit odd. If byte is less than zero,
then exit. Followed by another test for byte less than zero? Looks
like old and new code mixed.<br>
<br>
Cheers,<br>
Bob<br>
<br>
<br>
</font>
<div class="moz-cite-prefix">On 11/2/13 6:30 PM, Nicolas Cellier
wrote:<br>
</div>
<blockquote
cite="mid:CAKnRiT66gQhpUz68zmi6q-m9Ghkpzdo4VQZEVwySX+NnxW94Pw@mail.gmail.com"
type="cite">
<pre wrap=""> </pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<div dir="ltr">
<div>In recent COG, I see:<br>
<br>
LittleEndianBitmap>>byteAt: byteAddress put: byte<br>
"Insert a byte into a Bitmap (little-endian version).
N.B. Signedness will be lost since byteAt: answers
non-negative values.<br>
We can add a signedByteAt: if needed."<br>
| value longWord shift lowBits longAddr |<br>
(byte < 0 or:[byte > 255]) ifTrue:[^self
errorImproperStore].<br>
value := byte < 0<br>
ifTrue: [byte < 128 ifTrue:<br>
[self errorImproperStore].<br>
<br>
</div>
It looks suspect to me, wouldn't the intention be <br>
<br>
ifTrue: [byte < -128 ifTrue:<br>
[self errorImproperStore].</div>
</blockquote>
<br>
</body>
</html>