<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Nov 2, 2013 at 3:54 PM, Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank">nicolas.cellier.aka.nice@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br><div dir="ltr">I presume that the idea was to accept signed char, but interpret as unsigned, like a dirty cast...<br>
</div></blockquote><div><br></div><div>that's the intent. I should comment it.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">2013/11/2 Bob Arning <span dir="ltr"><<a href="mailto:arning315@comcast.net" target="_blank">arning315@comcast.net</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br>
<div text="#000000" bgcolor="#FFFFFF">
<font face="Georgia">Looks a bit odd. If byte is less than zero,
then exit. Followed by another test for byte less than zero? Looks
like old and new code mixed.<br>
<br>
Cheers,<br>
Bob<br>
<br>
<br>
</font>
<div>On 11/2/13 6:30 PM, Nicolas Cellier
wrote:<br>
</div>
<blockquote type="cite">
<pre> </pre>
<br>
<fieldset></fieldset>
<br>
<div dir="ltr">
<div>In recent COG, I see:<br>
<br>
LittleEndianBitmap>>byteAt: byteAddress put: byte<br>
"Insert a byte into a Bitmap (little-endian version).
N.B. Signedness will be lost since byteAt: answers
non-negative values.<br>
We can add a signedByteAt: if needed."<br>
| value longWord shift lowBits longAddr |<br>
(byte < 0 or:[byte > 255]) ifTrue:[^self
errorImproperStore].<br>
value := byte < 0<br>
ifTrue: [byte < 128 ifTrue:<br>
[self errorImproperStore].<br>
<br>
</div>
It looks suspect to me, wouldn't the intention be <br>
<br>
ifTrue: [byte < -128 ifTrue:<br>
[self errorImproperStore].</div>
</blockquote>
<br>
</div>
<br></blockquote></div><br></div>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div>
</div></div>