<div dir="ltr">Hi Nicolas,<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jan 1, 2014 at 1:16 AM, Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank">nicolas.cellier.aka.nice@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> <div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">
2013/12/31 Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank">nicolas.cellier.aka.nice@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><div>I forgot to tell this was in COG branch.<br>
</div>This file is generated, and the type is inferred from InterpreterProxy>>positive64BitIntegerFor:<br>
</div>I guess that a correct <returnTypeC:#sqInt> annotation is missing here.<br>
</div><div><div><div class="gmail_extra"><br><br></div></div></div></blockquote><div>The question is why using InterpreterProxy from the plugin code generator?<br></div><div>I find it strange to scatter (and duplicate) C-generation hints in a code that is not intended to be C-generated...<br>
</div></div></div></div></blockquote><div><br></div><div>The problem is that the InterpreterProxy interface wasn't well-documented in Smalltalk. Instead the definitive code is in platforms/Cross/vm/sqVirtualMachine.[ch]. I think it is better to have InterpreterProxy define the return types (via the pragmas) and to use these definitions for tests. See VMInterfaceConsistencyTests>>#testInterpreterProxyInterface.</div>
<div><br></div><div>Since the default return type is sqInt there's no pragma to specify it. But I agree it would be preferrable to be explicit.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div><div class="gmail_extra"><div class="gmail_quote">2013/12/31 Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank">nicolas.cellier.aka.nice@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">positive64BitIntegerFor return type is declared sqLong, but should be sqInt (it returns an oop).</div>
</blockquote></div></div></div></div></blockquote></div></div></div></blockquote></div><div><br></div>-- <br>best,<div>Eliot</div>
</div></div>