<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">Morning, David.</div><div class="gmail_quote"><br></div><div class="gmail_quote">On Sun, Jul 20, 2014 at 9:04 AM, <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
David T. Lewis uploaded a new version of VMMaker to project VM Maker:<br>
<a href="http://source.squeak.org/VMMaker/VMMaker-dtl.348.mcz" target="_blank">http://source.squeak.org/VMMaker/VMMaker-dtl.348.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: VMMaker-dtl.348<br>
Author: dtl<br>
Time: 20 July 2014, 11:57:32.241 am<br>
UUID: 869e87ed-0476-48a8-bca8-fe779633f9ae<br>
Ancestors: VMMaker-dtl.347<br>
<br>
VMMaker 4.13.6<br>
Merge VMMaker.oscog-eem.826 except:<br>
- Do not add the #initialize methods, not required because variables are declared static, therefore guaranteed to be initialized to 0. Also would require code generator changes for special treatment of instance side #initialize..<br>
</blockquote><div><br></div><div>David, the #initialize methods /are/ needed. If one were to simulate this plugin (which vm developers /do/ do; none of the Cog VMs would exist without it) then the #initialize methods are required to initialize those variables to 0, not nil.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- Do not ^self unnecessarily, not required here and code generated changes would be needed.<br></blockquote><div><br></div><div>Could you give me the instances? I'm fairly sure I wouldn't have added a ^self if it wasn't needed. Maybe I mad a mistake?</div>
<div><br></div></div>-- <br>aloha,<div>Eliot</div>
</div></div>