<p dir="ltr">Hi Eliot,</p>
<p dir="ltr">The changes were:<br>
1. Fix a couple incorrect/faulty C type declarations for certain methods and scoped variables within the methods. <br>
2. Ensure functions which declare a return type will return some value at the end of the block (defaulting to null). <br>
3. Ensure assignments are properly casted when type data about the expression and variable is available.<br>
4. Ensure functions arguments are properly casted when type data about the function's parameters and the argument expressions is available.</p>
<p dir="ltr">Alex</p>
<div class="gmail_quote">On Oct 2, 2014 8:44 AM, "Eliot Miranda" <<a href="mailto:eliot.miranda@gmail.com">eliot.miranda@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br><div dir="auto"><div>Hi Alex,</div><div><br></div><div> can you summarize the changes you've made here?<br><br>Eliot (phone)</div><div><br>On Oct 1, 2014, at 7:23 PM, Alex Franchuk <<a href="mailto:alex.franchuk@gmail.com" target="_blank">alex.franchuk@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><span></span></div></blockquote><blockquote type="cite"><div>
Dave,<br>
<br>
The version of VMMaker I'm using is VMMaker-dtl.350.<br>
<br>
I believe that issue is due to an error on my part. I neglected to
test on plugins, just on the interpreter code (because for now I'm
only porting the barebones interpreter to Plan9). That plugin seems
to have exposed the error. I've posted a fixed change set to the
Mantis submission.<br>
<br>
Alex<br>
<br>
<div>On 10/01/2014 09:28 PM, David T. Lewis
wrote:<br>
</div>
<blockquote type="cite">
<pre> </pre>
<br>
<fieldset></fieldset>
<br>
<pre>On Wed, Oct 01, 2014 at 07:24:52PM -0400, David T. Lewis wrote:
</pre>
<blockquote type="cite">
<pre>On Wed, Oct 01, 2014 at 07:36:12AM -0400, David T. Lewis wrote:
</pre>
<blockquote type="cite">
<pre>
This is a new Mantis submission with a change set to address Posix
compliance for generated code.
<a href="http://bugs.squeak.org/view.php?id=7821" target="_blank">http://bugs.squeak.org/view.php?id=7821</a>
I expect that the changes would be applicable to both oscog and trunk VMM,
although so far I have only taken a quick look at it in VMM trunk.
</pre>
</blockquote>
<pre>
I am posting this to vm-dev just for the record:
Alex Franchuk (alex.franchuk at gmail dot com), the author of the changes
submitted in Mantis 7821, has confirmed that his updates are licensed MIT.
Alex has also joined the vm-dev list so questions and discussion can take
place here.
Alex, can you tell me the exact version of VMMaker (the VMMaker.xxxxx.mcz
from the repository) that you are using? I ran into a problem when I tried
generating the VM sources with your change set applied, but I have also been
trying to gradually update the VMMaker package with Eliot Miranda's changes
that he is making it the oscog branch, so it is likely that our versions
are not in sync. Thanks!
</pre>
</blockquote>
<pre>Attached is the debugger window at the point of failure when generating
BitBltPlugin from an image with VMMaker-bf.351 loaded, and Plan9-Compat.1.cs
change set added.
Dave
</pre>
</blockquote>
<br>
</div></blockquote></div><br></blockquote></div>