<div dir="ltr">Hi Nicolas,<br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 10, 2014 at 2:41 PM, Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank">nicolas.cellier.aka.nice@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> <br><div dir="ltr">Eliot,<br>concerning CAS, are these the changes I submitted, or some concurrent implementation?<br></div></blockquote><div><br></div><div>They're the current Cog definitions in sqAtomicOps.h & sqMemoryFence.h corrected for x86_64. They use the __sync_... gcc builtins if available, falling back on gcc extended asm if not, i.e. for the win32 VM compiled using gcc 3.x. The __sync_ version are available in gcc as of 4.1, and are in clang. On iPhone they use the relevant SDK builtin, e.g. OSAtomicCompareAndSwap32 or OSAtomicCompareAndSwap64.</div><div><br></div><div>Please review?</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"></div><div class="gmail_extra"><br><div class="gmail_quote">2014-12-10 21:28 GMT+01:00 <span dir="ltr"><<a href="mailto:commits@squeakvm.org" target="_blank">commits@squeakvm.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
Revision: 3166<br>
Author: eliot<br>
Date: 2014-12-10 12:28:32 -0800 (Wed, 10 Dec 2014)<br>
Log Message:<br>
-----------<br>
<br>
Use the gcc/clang built-ins for CAS and atomic increment if available.<br>
<br>
A few more 64-bit changes to the Carbon implementation of the Mac subsystem,<br>
taking it as far as I can before admitting defeat and switching to the Cocoa<br>
implementation.<br>
<br>
Add a linux 64-bit build tree.<br>
<br>
Shed the old external platforms/iOS tree and import the latest pharovm tree<br>
(as of:<br>
commit 4feca169ed2abe8b3df0c0d0b9cd1f980a84e723<br>
Merge: 447f247 3c7a588<br>
Author: Esteban Lorenzano <<a href="mailto:estebanlm@gmail.com" target="_blank">estebanlm@gmail.com</a>><br>
Date: Fri Dec 5 07:54:51 2014 +0100<br>
<br>
Merge pull request #70 from nicolaihess/issue_14340<br>
<br>
use the same value for charCode and keyValue for mousewheelevents)<br></blockquote></div></div></blockquote></div><div><br></div>-- <br><div class="gmail_signature">best,<div>Eliot</div></div>
</div></div>