<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">2014-12-19 4:31 GMT+01:00 David T. Lewis <span dir="ltr"><<a href="mailto:lewis@mail.msen.com" target="_blank">lewis@mail.msen.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Hi Marcel,<br>
<br>
Thanks for doing this.<br>
<br>
I opened a Mantis issue so that we will not forget to integrate your changes:<br>
<br>
<a href="http://bugs.squeak.org/view.php?id=7825" target="_blank">http://bugs.squeak.org/view.php?id=7825</a><br>
<br>
Currently, the SVN trunk and oscog branches are identical for sqWin32FilePrims.c,<br>
so your update can be applied to both.<br>
<br>
Your update in the file header looks fine to me. It does not affect copyright,<br>
you are just adding a comment to document your update, which is great:<br>
<br>
* UPDATES:<br>
* 1) Support for long path names added by using UNC prefix in that case<br>
* (Marcel Taeumel, Hasso Plattner Institute, Postdam, Germany)<br>
<br>
Eliot - I am not able to test this, but I am sure that Marcel has done so.<br>
If this looks good to you then I think we should commit the update to both<br>
oscog and trunk in SVN. I think we both have write access to the win32 tree<br>
in SVN trunk, so I'm happy to make the update if you agree (or I think you can<br>
do it also if you prefer, whichever is easier).<br>
<br>
I'll close out the Mantis issue whenever we get this completed.<br>
<br>
Thanks,<br>
Dave<br>
<div class=""><div class="h5"><br>
<br>
<br>
On Tue, Dec 16, 2014 at 12:59:05AM -0800, Marcel Taeumel wrote:<br>
><br>
> sqWin32FilePrims.c <<a href="http://forum.world.st/file/n4796107/sqWin32FilePrims.c" target="_blank">http://forum.world.st/file/n4796107/sqWin32FilePrims.c</a>><br>
><br>
> Hi, Eliot! :)<br>
><br>
> Here is the second version that uses alloca. I also modified FAIL to<br>
> represent a block thinking of Heartbleed. :D I am not that much into C<br>
> patterns. You are free change that.<br>
><br>
> Another thing is about the copyright information at the beginning of the<br>
> file. I added something, but what is the correct format?<br>
><br>
> Best,<br>
> Marcel<br>
><br>
><br>
><br>
> --<br>
> View this message in context: <a href="http://forum.world.st/Long-path-name-support-added-for-win32-tp4796045p4796107.html" target="_blank">http://forum.world.st/Long-path-name-support-added-for-win32-tp4796045p4796107.html</a><br>
> Sent from the Squeak VM mailing list archive at Nabble.com.<br>
</div></div></blockquote></div><br><br></div><div class="gmail_extra">I just found this because I tried to add long path support to pharo.<br></div><div class="gmail_extra">What about methods for working with directories dir_create/dir_lookup ....<br></div><div class="gmail_extra">Don't you need to do the same in sqWin32Directory.c ?<br><br></div><div class="gmail_extra">nicolai<br></div><div class="gmail_extra"><br></div></div>