<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Hi Clément,</div><div><br></div><div> your code is quite correct. But the old code used two registers and I think that using two registers could be faster depending on processor micro architecture. So I wrote a version that used two registers if possible. Since I doubt it'll make any measurable difference (remote temps are rare and the cost of the sequence will be dominated by the reads) I reverted back to your original. But the support method might be useful. Sorry fir the noise.<br><br>Eliot (phone)</div><div><br>On Jun 27, 2015, at 3:25 PM, Clément Bera <<a href="mailto:bera.clement@gmail.com">bera.clement@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><span></span></div></blockquote><blockquote type="cite"><div><div dir="ltr">I am confused, what did you do in the two last commits ?<div><br></div><div>What is <span style="font-size:12.8000001907349px">example response ?</span></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">Was my code correct ? I tried the simulator only and it worked fine. </span></div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-06-27 21:44 GMT+02:00 <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Eliot Miranda uploaded a new version of VMMaker to project VM Maker:<br>
<a href="http://source.squeak.org/VMMaker/VMMaker.oscog-eem.1391.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/VMMaker/VMMaker.oscog-eem.1391.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: VMMaker.oscog-eem.1391<br>
Author: eem<br>
Time: 27 June 2015, 12:43:14.39 pm<br>
UUID: bdc64a36-203a-4f8f-b8e9-53ef7e41bfb9<br>
Ancestors: VMMaker.oscog-eem.1390<br>
<br>
Revert back to Clément's version of<br>
genPushRemoteTempLongBytecode now that<br>
example response has been committed.<br>
<br>
=============== Diff against VMMaker.oscog-eem.1390 ===============<br>
<br>
Item was changed:<br>
----- Method: StackToRegisterMappingCogit>>genPushRemoteTempLongBytecode (in category 'bytecode generators') -----<br>
genPushRemoteTempLongBytecode<br>
+ | newReg |<br>
- | newReg freeReg |<br>
newReg := self allocateRegNotConflictingWith: 0.<br>
+ self MoveMw: (self frameOffsetOfTemporary: byte2) r: FPReg R: newReg.<br>
- freeReg := self availableRegNotConflictingWith: (self registerMaskFor: newReg).<br>
- self MoveMw: (self frameOffsetOfTemporary: byte2) r: FPReg R: (freeReg ifNil: newReg).<br>
objectRepresentation<br>
genLoadSlot: byte1<br>
+ sourceReg: newReg<br>
- sourceReg: (freeReg ifNil: newReg)<br>
destReg: newReg.<br>
^self ssPushRegister: newReg!<br>
<br>
</blockquote></div><br></div>
</div></blockquote></body></html>