<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 29, 2015 at 4:28 PM, Tobias Pape <span dir="ltr"><<a href="mailto:Das.Linux@gmx.de" target="_blank">Das.Linux@gmx.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
<span class="">On 25.07.2015, at 01:10, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com">eliot.miranda@gmail.com</a>> wrote:<br>
<br>
> Hi Levente,<br>
><br>
</span><span class="">> On Fri, Jul 24, 2015 at 3:46 PM, Levente Uzonyi <<a href="mailto:leves@elte.hu">leves@elte.hu</a>> wrote:<br>
> Hi Eliot,<br>
><br>
>> Yes, the github version lacks that line. My pull request[1] has this fix, along with a few other fixes and improvments, but Tobias didn't like the image-sided SAN certificate validation scheme, so none of those have been merged. In the meanwhile I've started rewriting a few things, like logging, certificate serialization (so that it's accessible from the image), but I still haven't finished domain name validation.<br>
><br>
> OK, I'll keep the version of sqUnixOpenSSL.c in Cog unchanged except for the use of SQSSL_VERSION for the version number.<br>
<br>
</span>Reading the Cog sources, sqUnixOpenSSL.c:422 reads<br>
case SQSSL_PROP_VERSION: return 1;<br>
which should be<br>
case SQSSL_PROP_VERSION: return SQSSL_VERSION;<br>
<br>
Just to make sure, the version SQSSL_VERSION should be 2.<br></blockquote><div><br></div><div>Right. The fix is on deck, awaiting a commit. I guess I can commit before fixing the build. I'll do it now.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br>
> Maybe you can integrate with the Cog version? I like using %p instead of %lx,<br>
<br>
</span>done in c4cad6e81dac6e2475de3426dc613ec50226b230<br>
(sorry, I mixed that with \r\n -> \n conversion, very sorry)<br>
<span class=""><br>
<br>
> and the use of (long)aSqInt variable is I think unnecessary. Whether sqInt is int or long it=ll get passed as a long to printf, so the noise is unnecessary.<br>
<br>
</span>Yet, I'd get warnings:<br>
if sqInt is an int,<br>
printf("%ld", aSqInt)<br>
gives a format waring<br>
warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'int'<br>
so I would use %d like the Cog version does.<br>
Yet, then, if sqInt is a long,<br>
printf("%d", aSqInt)<br>
gives a format warning again:<br>
warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int'<br>
<br>
So I'd tend to not change the<br>
printf("%ld", (long)aSqInt);<br>
as it works correctly and without warnings in both cases.<br>
<span class=""><br>
<br>
<br>
><br>
> Do you have installation instructions for LibreSSL and make flags for linux64 & linux32?<br>
><br>
<br>
</span>I try to put that together tomorrow, I managed to reach 1:30 am again...<br>
<br>
Best<br>
<span class="HOEnZb"><font color="#888888"> -Tobias</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</div></div>