<div dir="ltr">Hi Nicolas,<br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 10, 2015 at 11:45 PM, Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank">nicolas.cellier.aka.nice@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-08-11 2:08 GMT+02:00 Eliot Miranda <span dir="ltr"><<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br><div dir="auto"><div>Hi Nicolas,</div><div><br>On Aug 10, 2015, at 1:32 PM, Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank">nicolas.cellier.aka.nice@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div>Hum, but then wait, see suspicious code below</div></blockquote><div><br></div>[snip]<br><br><blockquote type="cite"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div><div><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Item was changed:<br>
----- Method: SimpleStackBasedCogit>>genPrimitiveLessThan (in category 'primitive generators') -----<br>
genPrimitiveLessThan<br>
+ ^self<br>
+ genSmallIntegerComparison: JumpLess<br>
+ orDoubleComparison: #JumpFPGreaterOrEqual:<div><br></div></blockquote></div></div></div></div></blockquote></div></div></div></blockquote></div></div></div></div></div></blockquote><div>and shouldn't it be JumpFPGreater ???</div></blockquote><br><div>No. (a>b) = !(b>=a); (a>b) != !(b>a) if a = b.</div></div><br></blockquote></div><br></div><div class="gmail_extra">Hi Eliot,<br>it seems that you are mixing the two algorithms, the old one and the new one<br><br></div><div class="gmail_extra">(a < b) = ( a >= b) not<br>is wrong and doesn't work with NaN<br></div><div class="gmail_extra">it was the old implementation which inverted < into >=<br><br></div><div class="gmail_extra">(a < b) = (b > a)<br>is OK and is what you implemented now by reverting the parameters<br></div><div class="gmail_extra">so < must be inverted in ><br><br></div><div class="gmail_extra">look again and test with 2 <= 2.0<br></div></div></blockquote><div><br></div><div>You're right! I got hopelessly confused. Thanks for your patience. Fixing the code now, taking time to fix some minor warnings elsewhere.</div><div><br></div></div><div class="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</div></div>