<div dir="ltr">Ok. Committed Collections-cbc.652.mcz to the inbox. It has a faster unsignedLong64At:put:bigEndian:. It essentially used the ma code, but checks for endianness to make it work in those situations.<div><br></div><div>Speed test:</div><div><br></div><div><div>smallN := ((2 raisedTo: 13) to: (2 raisedTo: 14)) atRandom.</div><div>largeN := ((2 raisedTo: 63) to: (2 raisedTo: 64)) atRandom.</div><div>maBa := ByteArray new: 8.</div><div>cbBa := ByteArray new: 8.</div><div>maBa maUint: 64 at: 0 put: largeN.</div><div>cbBa unsignedLong64At: 1 put: largeN bigEndian: false.</div><div>self assert: (cbBa maUnsigned64At: 1) = (maBa unsignedLong64At: 1 bigEndian: false).</div><div>self assert: (cbBa maUnsigned64At: 1) = (cbBa unsignedLong64At: 1 bigEndian: false).</div><div><br></div><div>{</div><div>'cbc smallN write' -> [ cbBa unsignedLong64At: 1 put: smallN bigEndian: false] bench.</div><div>'ma smallN write' -> [cbBa maUint: 64 at: 0 put: smallN ] bench.</div><div>'cbc largeN write' -> [ cbBa unsignedLong64At: 1 put: largeN bigEndian: false] bench.</div><div>'ma largeN write' -> [cbBa maUint: 64 at: 0 put: largeN ] bench.</div><div> }</div><div> {</div><div>'cbc smallN write'->'3,770,000 per second. 266 nanoseconds per run.' . </div><div>'ma smallN write'->'3,700,000 per second. 270 nanoseconds per run.' . </div><div>'cbc largeN write'->'4,190,000 per second. 238 nanoseconds per run.' . </div><div>'ma largeN write'->'4,120,000 per second. 243 nanoseconds per run.'</div><div>}</div></div><div><br></div><div>I would like to have this pushed to Trunk so that we have a shared 64bit access to ByteArrays. I know of at least 3 places this has been coded: my code, VMMaker, and MA Serializable. Probably several other places exist.</div><div><br></div><div>The put code (benchmarked above) shouldn't be affected if it is run in a 64 bit image - if anything just a bit faster.</div><div><br></div><div>The get code (also in the committed code) should not get any slower in a 64 bit image, but if the SmallInteger uses more </div><div>bits in its representation than the 32 bit image, it could be optimized to run faster there at the cost of running slower on 32 bit images. So probably not worth fixing in this code. If you* do make a primitive for these accesses, then those would obviously be made significantly faster, and this could be the fallback code.</div><div><br></div><div>(* having never made a primitive nor compiled the image - yet - I probably won't be added these. And I don't need that speed myself at this point, either.)</div><div><br></div><div>-cbc</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 31, 2015 at 8:21 PM, Chris Cunningham <span dir="ltr"><<a href="mailto:cunningham.cb@gmail.com" target="_blank">cunningham.cb@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Andres,<div><br></div><div>ByteArray currently doesn't have a primitive that handles any part of getting bytes from the ByteArray and forming them into an integer. If it did have one, I would be happy to alter the code around that.</div><div><br></div><div>The long drawn out method is 4x faster for small (SmallInteger) results, and 25% faster for LargeInteger results (those that excercise all 8 bytes). This because it does at most 2 LargeInteger bitShifts, and as little as no LargeInteger bitShifts. The 'macro' version does a minimum of 1 LargeInteger bitShifts, and up to 3 of them.</div><div><br></div><div>For BigEndian platforms, speed may be important; in any case, it is nice.</div><div><br></div><div>You are probably aware, but the current Squeak has does not have #unsignedLong64At:bigEndian: in the image at all - that diff was from my first attempt.</div><div><br></div><div>-cbc</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 31, 2015 at 7:39 PM, Andres Valloud <span dir="ltr"><<a href="mailto:avalloud@smalltalk.comcastbiz.net" target="_blank">avalloud@smalltalk.comcastbiz.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Interesting about the fading relevancy of big endian platforms. Just in case the point was lost, I meant the macro-style approach in contrast with this (from Squeak-dev):<br>
<br>
=============== Diff against Collections-cbc.650 ===============<br>
<br>
Item was changed:<br>
----- Method: ByteArray>>unsignedLong64At:bigEndian: (in category 'platform independent access') -----<br>
unsignedLong64At: index bigEndian: aBool<br>
+ "Avoid as much largeInteger as we can"<br>
+ | b0 b2 b3 b5 b6 w n2 n3 |<br>
+<br>
+ aBool ifFalse: [<br>
+ w := self at: index.<br>
+ b6 := self at: index+1.<br>
+ b5 := self at: index+2.<br>
+ n2 := self at: index+3.<br>
+ b3 := self at: index+4.<br>
+ b2 := self at: index+5.<br>
+ n3 := self at: index+6.<br>
+ b0 := self at: index+7.<br>
+ ] ifTrue: [<br>
+ b0 := self at: index.<br>
+ n3 := self at: index+1.<br>
+ b2 := self at: index+2.<br>
+ b3 := self at: index+3.<br>
+ n2 := self at: index+4.<br>
+ b5 := self at: index+5.<br>
+ b6 := self at: index+6.<br>
+ w := self at: index+7.<br>
+ ].<br>
+<br>
+ "Minimize LargeInteger arithmetic"<br>
+ b6 = 0 ifFalse:[w := (b6 bitShift: 8) + w].<br>
+ b5 = 0 ifFalse:[w := (b5 bitShift: 16) + w].<br>
+ <br>
+ b3 = 0 ifFalse:[n2 := (b3 bitShift: 8) + n2].<br>
+ b2 = 0 ifFalse:[n2 := (b2 bitShift: 16) + n2].<br>
+ n2 == 0 ifFalse: [w := (n2 bitShift: 24) + w].<br>
+<br>
+ b0 = 0 ifFalse:[n3 := (b0 bitShift: 8) + n3].<br>
+ n3 == 0 ifFalse: [w := (n3 bitShift: 48) + w].<br>
+<br>
+ ^w!<br>
- | n1 n2 |<br>
- aBool<br>
- ifTrue: [<br>
- n2 := self unsignedLongAt: index bigEndian: true.<br>
- n1 := self unsignedLongAt: index+4 bigEndian: true.<br>
- ]<br>
- ifFalse: [<br>
- n1 := self unsignedLongAt: index bigEndian: false.<br>
- n2 := self unsignedLongAt: index+4 bigEndian: false.<br>
- ].<br>
- ^(n2 bitShift: 32) + n1!<br>
<br>
<br>
I'd rather have that pushed down enough so that the compiler intrinsic becomes visible. And at that point, all that code is reduced to a single instruction.<span><font color="#888888"><br>
<br>
Andres.</font></span><div><div><br>
<br>
<br>
On 8/31/15 19:12 , Eliot Miranda wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
Hi Andres,<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Aug 31, 2015, at 5:52 PM, Andres Valloud <<a href="mailto:avalloud@smalltalk.comcastbiz.net" target="_blank">avalloud@smalltalk.comcastbiz.net</a>> wrote:<br>
<br>
FWIW... IMO it's better to enable access to the relevant compiler intrinsic with platform specific macros, rather than implementing instructions such as Intel's BSWAP or MOVBE by hand. In HPS, isolating endianness concerns from the large integer arithmetic primitives with such macros enabled 25-40% faster performance on big endian platforms. Just as importantly, the intrinsic approach takes significantly less code to implement.<br>
</blockquote>
<br>
Makes sense, and the performance increases are impressive. The only issue I have is that the Cog JIT (which would have the easiest time generating those intrinsics) currently runs only in little-endianness platforms and I seriously doubt it will run in a big endianness platform in the next five years. PowerPC is the only possibility I see. Yes, ARM is biendian but all the popular applications I know of are little endian.<br>
<br>
VW's a different beast; significant big endian legacy.<br>
<br>
But what you say about isolating makes perfect sense. Thanks<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 8/31/15 10:25 , Eliot Miranda wrote:<br>
Hi Chrises,<br>
<br>
my vote would be to write these as 12 numbered primitives, (2,4 & 8<br>
bytes) * (at: & at:put:) * (big & little endian) because they can be<br>
performance critical and implementing them like this means the maximum<br>
efficiency in both 32-bit and 64-bit Spur, plus the possibility of the<br>
JIT implementing the primitives.<br>
<br>
On Sun, Aug 30, 2015 at 10:01 PM, Chris Cunningham<br>
<<a href="mailto:cunningham.cb@gmail.com" target="_blank">cunningham.cb@gmail.com</a> <mailto:<a href="mailto:cunningham.cb@gmail.com" target="_blank">cunningham.cb@gmail.com</a>>> wrote:<br>
<br>
Hi Chris,<br>
<br>
I'm all for having the fastest that in the image that works. If you<br>
could make your version handle endianess, then I'm all for including<br>
it (at least in the 3 variants that are faster). My first use for<br>
this (interface for KAFKA) apparently requires bigEndianess, so I<br>
really want that supported.<br>
<br>
It might be best to keep my naming, though - it follows the name<br>
pattern that is already in the class. Or will yours also support 128?<br>
<br>
-cbc<br>
<br>
On Sun, Aug 30, 2015 at 2:38 PM, Chris Muller <<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a><br>
<mailto:<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>>> wrote:<br>
<br>
Hi Chris, I think these methods belong in the image with the fastest<br>
implementation we can do.<br>
<br>
I implemented 64-bit unsigned access for Ma Serializer back in 2005.<br>
I modeled my implementation after Andreas' original approach which<br>
tries to avoid LI arithmetic. I was curious whether your<br>
implementations would be faster, because if they are then it could<br>
benefit Magma. After loading "Ma Serializer" 1.5 (or head) into a<br>
trunk image, I used the following script to take comparison<br>
measurements:<br>
<br>
| smallN largeN maBa cbBa | smallN := ((2 raisedTo: 13) to: (2<br>
raisedTo: 14)) atRandom.<br>
largeN := ((2 raisedTo: 63) to: (2 raisedTo: 64)) atRandom.<br>
maBa := ByteArray new: 8.<br>
cbBa := ByteArray new: 8.<br>
maBa maUint: 64 at: 0 put: largeN.<br>
cbBa unsignedLong64At: 1 put: largeN bigEndian: false.<br>
self assert: (cbBa maUnsigned64At: 1) = (maBa unsignedLong64At: 1<br>
bigEndian: false).<br>
{ 'cbc smallN write' -> [ cbBa unsignedLong64At: 1 put: smallN<br>
bigEndian: false] bench.<br>
'ma smallN write' -> [cbBa maUint: 64 at: 0 put: smallN ] bench.<br>
'cbc smallN access' -> [ cbBa unsignedLong64At: 1 bigEndian:<br>
false. ] bench.<br>
'ma smallN access' -> [ cbBa maUnsigned64At: 1] bench.<br>
'cbc largeN write' -> [ cbBa unsignedLong64At: 1 put: largeN<br>
bigEndian: false] bench.<br>
'ma largeN write' -> [cbBa maUint: 64 at: 0 put: largeN ] bench.<br>
'cbc largeN access' -> [ cbBa unsignedLong64At: 1 bigEndian:<br>
false ] bench.<br>
'ma largeN access' -> [ cbBa maUnsigned64At: 1] bench.<br>
}<br>
<br>
Here are the results:<br>
<br>
'cbc smallN write'->'3,110,000 per second. 322 nanoseconds per<br>
run.' .<br>
'ma smallN write'->'4,770,000 per second. 210 nanoseconds per<br>
run.' .<br>
'cbc smallN access'->'4,300,000 per second. 233 nanoseconds per<br>
run.' .<br>
'ma smallN access'->'16,400,000 per second. 60.9 nanoseconds<br>
per run.' .<br>
'cbc largeN write'->'907,000 per second. 1.1 microseconds per<br>
run.' .<br>
'ma largeN write'->'6,620,000 per second. 151 nanoseconds per<br>
run.' .<br>
'cbc largeN access'->'1,900,000 per second. 527 nanoseconds per<br>
run.' .<br>
'ma largeN access'->'1,020,000 per second. 982 nanoseconds per<br>
run.'<br>
<br>
It looks like your 64-bit access is 86% faster for accessing the<br>
high-end of the 64-bit range, but slower in the other 3 metrics.<br>
Noticeably, it was only 14% as fast for writing the high-end of the<br>
64-bit range, and similarly as much slower for small-number access..<br>
<br>
<br>
On Fri, Aug 28, 2015 at 6:01 PM, Chris Cunningham<br>
<<a href="mailto:cunningham.cb@gmail.com" target="_blank">cunningham.cb@gmail.com</a> <mailto:<a href="mailto:cunningham.cb@gmail.com" target="_blank">cunningham.cb@gmail.com</a>>> wrote:<br>
> Hi.<br>
><br>
> I've committed a change to the inbox with changes to allow<br>
getting/putting<br>
> 64bit values to ByteArrays (similar to 32 and 16 bit<br>
accessors). Could this<br>
> be added to trunk?<br>
><br>
> Also, first time I used the selective commit function - very<br>
nice! the<br>
> changes I didn't want committed didn't, in fact, get<br>
commited. Just the<br>
> desirable bits!<br>
><br>
> -cbc<br>
><br>
><br>
><br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
--<br>
_,,,^..^,,,_<br>
best, Eliot<br>
<br>
<br>
<br>
</blockquote></blockquote></div></div>
.<br>
<br>
</blockquote>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>