<div dir="ltr">Hi David,<div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 20, 2015 at 3:20 PM, David T. Lewis <span dir="ltr"><<a href="mailto:lewis@mail.msen.com" target="_blank">lewis@mail.msen.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
On Tue, Oct 20, 2015 at 01:48:35PM -0700, John McIntosh wrote:<br>
><br>
> Ok, you know there is a test plugin squeakSUnitTester (See the *m/h files)<br>
> I made to check types being passed to/from the Objective-C interface to<br>
> confirm things are being transferred/received correctly. However I did<br>
> write something similar for the FFI interface where, or using using<br>
> Smalltalk code where I iterated over the entire range of +/- 2 billion then<br>
> edge cases for LargePositive/Negative integers for each point where we<br>
> added another byte of accuracy for a few bytes. The reasons for that was<br>
> to confirm that integer conversion was working correctly for all cases when<br>
> we had migrated to 32bit clean code a decade back.<br>
><br>
<br>
Hi John,<br>
<br>
It wasn't really a decade back. Well not quite ;-)<br>
<br>
Your mention of the FFI interface reminds me of the work we did to make<br>
the old FFI 32/64 bit clean. We never got that harvested into the VM, but<br>
the patches circa 2008 are still out there on the Mantis report at<br>
<a href="http://bugs.squeak.org/view.php?id=7237" rel="noreferrer" target="_blank">http://bugs.squeak.org/view.php?id=7237</a><br>
<br>
I truly do not know if this has relevance any more, but maybe you and Eliot<br>
could comment? There were pointer size issues that had to be addressed in<br>
the image as well as in the plugin and support code, so some of it might<br>
still be of interest.<br></blockquote><div><br></div><div>I *think* that the new ThreadedFFIPlugin-derived FFIs are 32/64-bit clean but its not been tested thoroughly. These plugins don't use any assembly, compile to pure C with perhaps two asm statements in them to get/set the stack pointer if alloca doesn't do exactly the right thing. But there's no code in there that assumes 32-bit sizes. We'll know soon enough.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Dave<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</div></div>