<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-10-28 22:27 GMT+01:00 Tobias Pape <span dir="ltr"><<a href="mailto:Das.Linux@gmx.de" target="_blank">Das.Linux@gmx.de</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Hi,<br>
<span class=""><br>
On 28.10.2015, at 22:21, Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>> wrote:<br>
<br>
> Just in case, I put a copy here of the changes I had to perform for El Capitan/clang 7.0 with ARC enabled.<br>
><br>
> These are diffs from svn 3478 (svn patch compatible).<br>
> The one concerning the commented TARGET_API_MAC_CARBON is questionable - it should probably be conditional (#ifdef something...). If the patch is applied as is, the macro should be defined in the command line for compiling legacy Mac Carbon VM.<br>
<br>
</span>Caution, TARGET_API_MAC_CARBON is used in several places in the vm to<br>
distinguish pre-Carbon OS 9,8,… and Carbon OS X. It also applies to some<br>
cocoa-OK code.<br>
<br></blockquote><div><br></div><div>As I said, I'm not sure about this one, this was a quick fix that I had to do to compile 64bits with clang 7.0...<br></div><div>I just retried now and I see that this is due to a missing declaration<br> MenuItemIndex outIndex;<br></div><div>in primitiveGetIndMenuWithCommandID<br><br></div><div>It seems that the variable is declared, but only used in a cCode: verbatim insertion...<br></div><div>Maybe modern CCodeGenerator does eliminate the variable as unused.<br></div><div>So there might be a better fix :)<br><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
also, your patch does several<br>
- int SomePtr<br>
+ char* SomePtr<br>
I think this is dangerous. Do we really know these are char pointers?<br>
Also, if we have to know these are integerlike things, what about intptr_t here?<br>
<br></blockquote><div>I think that char pointers are OK for sqMacMidi.[cm] it's a pointer to either ByteString or ByteArray data if we trust the comments.<br></div><div>Maybe unsigned char *?<br></div><div>In all cases, int is definitely an error for a 64bits VM.<br><br></div><div>And in all cases, thanks for reviewing!<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Best regards<br>
<span class=""><font color="#888888"> -Tobias<br>
</font></span><div class=""><div class="h5"><br>
><br>
><br>
><br>
><br>
> 2015-10-23 23:09 GMT+02:00 Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>>:<br>
> In platforms/iOS/vm/SqueakPureObjc_Prefix.pch, shouldn't the macros be defined<br>
><br>
> #if ...<br>
> #define RELEASEOBJ(x)<br>
> #else<br>
> #define RELEASEOBJ(x) [x release]<br>
> #endif<br>
><br>
> same for autorelease and retain<br>
><br>
> because I currently have compilation errors with ARC enabled and clang 7.0<br>
><br>
> It also seems that #define SUPERDEALLOC is missing in the ARC branch.<br>
><br>
> Thanks<br>
<br>
<br>
</div></div></blockquote></div><br></div></div>