<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Hi Nicolas,<br><br><br></div><div><br>On Apr 7, 2016, at 11:50 PM, Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>> wrote:<br></div><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">2016-04-08 2:26 GMT+02:00 <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Eliot Miranda uploaded a new version of VMMaker to project VM Maker:<br>
<a href="http://source.squeak.org/VMMaker/VMMaker.oscog-eem.1779.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/VMMaker/VMMaker.oscog-eem.1779.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: VMMaker.oscog-eem.1779<br>
Author: eem<br>
Time: 7 April 2016, 5:26:14.093395 pm<br>
UUID: eb3139fc-9d6f-432c-83b9-099675dcb37d<br>
Ancestors: VMMaker.oscog-eem.1778<br>
<br>
Fix simulation of the LargeIntegersPlugin. The issue is that interpreterProxy firstIndexableField: answers a CArray whose unitSize reflects the object's unit size, and becuase LargeIntegers are byte objects, the CArray is a byte accssor by default. So add InterpreterPlugin>>firstIndexableField:as:, which uses cCoerce:to: to provide a CArray typed as requested, and use it everywhere the LargeIntegersPlugin takes the firstIndexableField of a LargeInteger, and cast to #'unsigned int *'.<br>
<br>
Go some way to speed up the warppers by<br>
a) improving CArray>at:[put:] to assume unitSize is a suitable power of two, and<br>
b) add CFloatArray to access float or double<br>
<br>
Later on we can add CUnsignedIntegerArray, as required.<br>
<br>
<br>
N.B. While this fixes simulation of the LargeIntegerPlugin there is still something wrong under simulation in whatever produces large fonts. Start up the Squeak 5.0 release image with the "Squeak 5.0 Release Notes" text in huge letters in a workspace towards the front and you'll notice that in the simulator none of the large fonts are displayed, although the text from "Fast Become" works fine.<br>
<br>
=============== Diff against VMMaker.oscog-eem.1778 ===============<br><br></blockquote></div></div></div></div></blockquote>...<br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Item was changed:<br>
----- Method: Integer>>coerceTo:sim: (in category '*VMMaker-interpreter simulator') -----<br>
coerceTo: cTypeString sim: interpreter<br>
<br>
| unitSize |<br>
cTypeString last = $* ifTrue: "C pointer"<br>
[unitSize := cTypeString caseOf: {<br>
['char *'] -> [1].<br>
['short *'] -> [2].<br>
['int *'] -> [4].<br>
+ ['float *'] -> [^CFloatArray basicNew interpreter: interpreter address: self unitSize: 4; yourself].<br>
+ ['double *'] -> [^CFloatArray basicNew interpreter: interpreter address: self unitSize: 8; yourself].<br>
- ['long *'] -> [interpreter wordSize].<br></blockquote><div><br></div><div>Hi Eliot,<br></div><div>I presume you suppressed long * and do not need unsigned long * because they are handled in otherwise.<br></div><div>But there's also no (unsigned) long long * / (u)sqLong *<br></div><div>We never coerce to these types (or only inside cCode: []), or this is handled elsewhere?<br></div></div></div></div></div></blockquote><div><br></div>It's just that the existing method didn't handle it. Right now I have other priorities with Clément (better block model for Sista plus a proper register allocator) but... <div>- it seems wrong that there are two cCoerce:to: implementations that differ; they should be the same</div><div>- they should be complete</div><div>- CArray can be a hierarchy so we can minimize the use of CPluggableAccessor</div><div>- we should bite the bullet and have byteAt: shortAt: long32At: <span style="background-color: rgba(255, 255, 255, 0);">long64At: & longAt: agree on signedness both in the simulator and in C and provide signedByteAt: & unsignedByteAt: et al</span></div><div><span style="background-color: rgba(255, 255, 255, 0);">- there should be tests other than just running the simulator</span></div><div><span style="background-color: rgba(255, 255, 255, 0);">- the default implementation of firstIndexableField: in the object memory simulators that answers a CArray whose unit type depends on the underlying element size of the object is highly questionable given that the type of firstIndexableField: is void *</span></div><div>- we should choose either 'float *' et al or <span style="background-color: rgba(255, 255, 255, 0);">'float*' et al, not both (I'm used to 'float *' et al) and slang should issue warnings for the alternative we reject.</span></div><div>- we have to choose whether char * is signed or not even if C compilers disagree; let's choose gcc's or clang's (hopefully they do agree)</div><div><br></div><div><br></div><div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- ['float *'] -> [4].<br>
- ['double *'] -> [8].<br>
['unsigned *'] -> [4].<br>
['unsigned int *'] -> [4].<br>
+ ['unsigned char *'] -> [1].<br>
+ ['signed char *'] -> [1].<br>
+ ['unsigned short *'] -> [2].<br>
- ['unsigned char *'] -> [4].<br>
- ['unsigned short *'] -> [4].<br>
['oop *'] -> [interpreter bytesPerOop].<br>
}<br>
+ otherwise: [interpreter wordSize].<br>
- otherwise: [ (cTypeString beginsWith: 'char') ifTrue: [1] ifFalse: [interpreter wordSize] ].<br>
^CArray basicNew<br>
interpreter: interpreter address: self unitSize: unitSize;<br>
yourself].<br>
+ ^self "C number (int, char, float, etc)"!<br>
- ^ self "C number (int, char, float, etc)"!<br>
<br>
Item was added:<br>
+ ----- Method: InterpreterPlugin>>firstIndexableField:as: (in category 'casting support') -----<br>
+ firstIndexableField: obj as: cType<br>
+ <inline: true><br>
+ ^interpreterProxy cCoerce: (interpreterProxy firstIndexableField: obj) to: cType!<br></blockquote></div></div></div></blockquote>...<br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
</blockquote></div></div></div>
</blockquote></div></body></html>