<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">and I confirm it works :)<div class=""><br class=""></div><div class="">Esteban</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 25 Apr 2016, at 21:41, Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com" class="">nicolas.cellier.aka.nice@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">And thanks to Esteban for pointing me to the bug.<br class=""><br class=""></div><div class="gmail_extra"><br class=""><div class="gmail_quote">2016-04-25 21:22 GMT+02:00 <span dir="ltr" class=""><<a href="mailto:commits@source.squeak.org" target="_blank" class="">commits@source.squeak.org</a>></span>:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class="">
Nicolas Cellier uploaded a new version of VMMaker to project VM Maker:<br class="">
<a href="http://source.squeak.org/VMMaker/VMMaker.oscog-nice.1843.mcz" rel="noreferrer" target="_blank" class="">http://source.squeak.org/VMMaker/VMMaker.oscog-nice.1843.mcz</a><br class="">
<br class="">
==================== Summary ====================<br class="">
<br class="">
Name: VMMaker.oscog-nice.1843<br class="">
Author: nice<br class="">
Time: 25 April 2016, 8:24:03.731 pm<br class="">
UUID: 9ef5d374-ae5e-437a-9116-cde9d708c0d7<br class="">
Ancestors: VMMaker.oscog-cb.1842<br class="">
<br class="">
Fix my recent bug for signed 32bit long access (introduced beginning of April).<br class="">
<br class="">
One symptom is:<br class="">
(Alien newGC: 4)<br class="">
signedLongAt: 1 put: -16r7287E552;<br class="">
signedLongAt: 1<br class="">
<br class="">
I incorrecly used the signed value (integerValue) in one branch, and the magnitude (value) in the other branch...<br class="">
This is an incorrect copy/paste from maybeInlinePositive32BitIntegerFor: in my ultimate #if SPURVM refactoring.<br class="">
<br class="">
While at it, avoid the confusion by using a better variable name (magnitude), and eliminate UB related to computing opposite of INT_MIN by explicitely using unsigned type.<br class="">
<br class="">
=============== Diff against VMMaker.oscog-cb.1842 ===============<br class="">
<br class="">
Item was changed:<br class="">
----- Method: StackInterpreter>>noInlineSigned32BitIntegerFor: (in category 'primitive support') -----<br class="">
noInlineSigned32BitIntegerFor: integerValue<br class="">
"Answer a full 32 bit integer object for the given integer value."<br class="">
<notOption: #Spur64BitMemoryManager><br class="">
+ | newLargeInteger magnitude largeClass |<br class="">
- | newLargeInteger value largeClass |<br class="">
<inline: false><br class="">
+ <var: 'magnitude' type: 'unsigned int'><br class="">
(objectMemory isIntegerValue: integerValue) ifTrue:<br class="">
[^objectMemory integerObjectOf: integerValue].<br class="">
self deny: objectMemory hasSixtyFourBitImmediates.<br class="">
integerValue < 0<br class="">
ifTrue: [largeClass := ClassLargeNegativeIntegerCompactIndex.<br class="">
+ magnitude := 0 asUnsignedInteger - integerValue]<br class="">
- value := 0 - integerValue]<br class="">
ifFalse: [largeClass := ClassLargePositiveIntegerCompactIndex.<br class="">
+ magnitude := integerValue].<br class="">
- value := integerValue].<br class="">
newLargeInteger := objectMemory<br class="">
eeInstantiateSmallClassIndex: largeClass<br class="">
format: (objectMemory byteFormatForNumBytes: 4)<br class="">
numSlots: 1.<br class="">
self cppIf: SPURVM<br class="">
ifTrue:<br class="">
["Memory is 8 byte aligned in Spur, make sure that oversized bytes are set to zero"<br class="">
+ objectMemory storeLong32: 0 ofObject: newLargeInteger withValue: (objectMemory byteSwapped32IfBigEndian: magnitude).<br class="">
- objectMemory storeLong32: 0 ofObject: newLargeInteger withValue: (objectMemory byteSwapped32IfBigEndian: integerValue).<br class="">
objectMemory storeLong32: 1 ofObject: newLargeInteger withValue: 0]<br class="">
ifFalse:<br class="">
+ [objectMemory storeLong32: 0 ofObject: newLargeInteger withValue: (objectMemory byteSwapped32IfBigEndian: magnitude)].<br class="">
- [objectMemory storeLong32: 0 ofObject: newLargeInteger withValue: (objectMemory byteSwapped32IfBigEndian: value)].<br class="">
^newLargeInteger!<br class="">
<br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>