<div dir="ltr"><div>SecureHashAlgorithmTests pass here on MacOSX 64 with DSAPrims module and <inline: #never> in #leftRotate:by:<br></div>Now it remains to fix inlining...<br></div><div class="gmail_extra"><br><div class="gmail_quote">2016-05-13 19:31 GMT+02:00 Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank">nicolas.cellier.aka.nice@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div>Hi Levente,<br></div>looking at code, my wild guess (but I did not try) is that #leftRotate:by: is incorrectly inlined...<br></div>The parameter should be cast to unsigned int (32 bits) otherwise extra bits will pollute the result.<br></div>Unfortunately, this method get inlined with sqInt argument which are 64bits long in 64bits version...<br></div>We really need to fix inlining.<br>I'll try with <inline: #never> if I have time to confirm/infirm the guess...<br><br><br><br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">2016-05-13 13:07 GMT+02:00 Levente Uzonyi <span dir="ltr"><<a href="mailto:leves@caesar.elte.hu" target="_blank">leves@caesar.elte.hu</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Hi All,<br>
<br>
As the subject says, the primitives work, but the SecureHashAlgorithmTests fail, because the prims miscalculate the values. I guess this is another integer type issue.<span><font color="#888888"><br>
<br>
Levente<br>
</font></span></blockquote></div><br></div>
</div></div></blockquote></div><br></div>