<div dir="ltr">Hi David,<div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 7, 2016 at 9:03 AM, David T. Lewis <span dir="ltr"><<a href="mailto:lewis@mail.msen.com" target="_blank">lewis@mail.msen.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
sqInt is not always large enough to hold a pointer, in particular for the<br>
common case of a 64-bit VM running a 32-bit object memory (yes I know<br>
there is not currently such a configuration for Cog/Spur). It would be<br>
good to avoid that assumption if possible.<br></blockquote><div><br></div><div>I wonder what the benefit of trying to maintain the 64-bit VM running a 32-bit object memory configuration is, now that we have an efficient 64-bit on 64-bit configuration. This is costly to maintain, and unless people really want to use it for me it feels like wasted effort. I realise it's your baby, and that it may have meaning. But it's also a hungry mouth to feed...</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Dave<br>
<br>
> Branch: refs/heads/Cog<br>
> Home: <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm</a><br>
> Commit: 08822ce610c20b61e1faec0ce72e635c8ad10e7c<br>
> <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/08822ce610c20b61e1faec0ce72e635c8ad10e7c" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/08822ce610c20b61e1faec0ce72e635c8ad10e7c</a><br>
> Author: Nicolas Cellier <<a href="mailto:nicolas.cellier@sirehna.com">nicolas.cellier@sirehna.com</a>><br>
> Date: 2016-07-07 (Thu, 07 Jul 2016)<br>
><br>
> Changed paths:<br>
> M platforms/win32/vm/sqWin32Backtrace.c<br>
><br>
> Log Message:<br>
> -----------<br>
> Revise valid macro for LLP64 case in sqWin32Backtrace.c<br>
><br>
> The code would have truncated fp bits because sizeof(long) > sizeof(fp) in<br>
> LLP64<br>
> It would have worked because we only inspect least significant bits for<br>
> alignment<br>
> But it's better to suppress suspicious compiler warning.<br>
> Thus use sqInt which is allways large enough to hold a pointer.<br>
><br>
><br>
><br>
<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</div></div>