<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2016-07-08 16:27 GMT+02:00 Ben Coman <span dir="ltr"><<a href="mailto:btc@openinworld.com" target="_blank">btc@openinworld.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
On Fri, Jul 8, 2016 at 5:44 PM, GitHub <<a href="mailto:noreply@github.com">noreply@github.com</a>> wrote:<br>
><br>
> Branch: refs/heads/Cog<br>
> Home: <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm</a><br>
> Commit: 931559445c72d9a53541289330ddb5157c94daf5<br>
> <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/931559445c72d9a53541289330ddb5157c94daf5" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/931559445c72d9a53541289330ddb5157c94daf5</a><br>
> Author: Nicolas Cellier <<a href="mailto:nicolas.cellier@sirehna.com">nicolas.cellier@sirehna.com</a>><br>
> Date: 2016-07-08 (Fri, 08 Jul 2016)<br>
><br>
> Changed paths:<br>
> M platforms/win32/vm/sqWin32Main.c<br>
><br>
> Log Message:<br>
> -----------<br>
> Replace another (UINT) cast by (usqIntptr_t) for LLP64 compatibility<br>
<br>
Just curious, why not put the "sq" at the front?<br>
It would seem to better categorise application specific types.<br>
cheers -ben<br>
<br></blockquote><div><br></div><div>I'm following existing pattern: sqInt usqInt sqLong usqLong ...<br></div><div>It's better both for uniformity and also because the pattern is exploited by special handling in CodeGenerator<br>(int types beginning with $u...)</div><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
><br>
> (UINT) would not work on LP64 anyway, it would truncate the pointer.<br>
><br>
><br>
><br>
</blockquote></div><br></div></div>