<div dir="ltr"><div><div><div><div>Thanks Tim,<br></div>I replicated this discussion as github comment<br><a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0aa65563f90b6f8f83a8126e37647bca4fda2ba5">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0aa65563f90b6f8f83a8126e37647bca4fda2ba5</a><br>because I feel like it's closer to the source code than this list.<br></div>However, since the comments are not reported here, I wonder what is the most efficient... (less eyes?).<br><br></div>Since the windows version is optional (subject to -DWIN32_FILE_SUPPORT), maybe we can keep my change.<br></div>On the other hand, the duplication sounds strange...<br>Having this compiler def. mandatory for MSVC would not hurt me.<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">2016-07-24 20:20 GMT+02:00 tim Rowledge <span dir="ltr"><<a href="mailto:tim@rowledge.org" target="_blank">tim@rowledge.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
HI Nicolas-<br>
> On 24-07-2016, at 10:13 AM, GitHub <<a href="mailto:noreply@github.com">noreply@github.com</a>> wrote:<br>
><br>
> Branch: refs/heads/Cog<br>
> Home: <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm</a><br>
> Commit: 0aa65563f90b6f8f83a8126e37647bca4fda2ba5<br>
> <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0aa65563f90b6f8f83a8126e37647bca4fda2ba5" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0aa65563f90b6f8f83a8126e37647bca4fda2ba5</a><br>
> Author: nicolas-cellier-aka-nice <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>><br>
> Date: 2016-07-24 (Sun, 24 Jul 2016)<br>
><br>
> Changed paths:<br>
> M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c<br>
><br>
> Log Message:<br>
> -----------<br>
> Replace fsync by FlushFileBuffers for MSVC<br>
<br>
I think Windows doesn’t actually use the Cross/blah-blah/sqFilePluginBasicPrims code? Or at least, I’m pretty sure I remember discovering that it didn’t some considerable time ago.<br>
Certainly the copies of the files I see on my fairly fresh update suggest I’m remembering correctly; note how /vm/platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c implements sqFileTruncate/sqImageFileSeek/etc,etc.<br>
<br>
<br>
tim<br>
--<br>
tim Rowledge; <a href="mailto:tim@rowledge.org">tim@rowledge.org</a>; <a href="http://www.rowledge.org/tim" rel="noreferrer" target="_blank">http://www.rowledge.org/tim</a><br>
Useful random insult:- Moves his lips to pretend he's reading.<br>
<br>
<br>
</blockquote></div><br></div>