<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2016-07-25 0:21 GMT+02:00 tim Rowledge <span dir="ltr"><<a href="mailto:tim@rowledge.org" target="_blank">tim@rowledge.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class=""><br>
<br>
> On 24-07-2016, at 2:10 PM, Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>> wrote:<br>
><br>
> Thanks Tim,<br>
> I replicated this discussion as github comment<br>
> <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0aa65563f90b6f8f83a8126e37647bca4fda2ba5" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/0aa65563f90b6f8f83a8126e37647bca4fda2ba5</a><br>
> because I feel like it's closer to the source code than this list.<br>
> However, since the comments are not reported here, I wonder what is the most efficient... (less eyes?).<br>
><br>
> Since the windows version is optional (subject to -DWIN32_FILE_SUPPORT), maybe we can keep my change.<br>
> On the other hand, the duplication sounds strange...<br>
> Having this compiler def. mandatory for MSVC would not hurt me.<br>
<br>
</span>I’m pretty sure that what happened was Andreas got annoyed enough at trying to make the unixy basic code work for Windows that he simply said to hell with it and split it out. In many ways I wish we’d all done that and realised that we need a much better set of file accessing code.<br>
<span class=""><br></span></blockquote><div><br></div><div><div>Andreas probably tried to get unixy compile with MSVC 5 or 6. Maybe it was hard at that time.<br>Now it's possible with a few StackOverflow queries and a few macros.<br></div>This way, I've reverted those changes and moved everything in sqPlatformSpecific.h<br></div><div>
I can define WIN32_FILE_SUPPORT or not, without polluting Cross/plugins.<br></div><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
<br>
tim<br>
--<br>
tim Rowledge; <a href="mailto:tim@rowledge.org">tim@rowledge.org</a>; <a href="http://www.rowledge.org/tim" rel="noreferrer" target="_blank">http://www.rowledge.org/tim</a><br>
</span>Useful random insult:- If you stand close enough to him, you can hear the ocean<br>
<br>
<br>
</blockquote></div><br></div></div>