<div dir="ltr"><div><div>Hi Henry,<br></div>it does not really matter because I virtually eliminated this definition<br></div><div>(I kept it just in case for very old compiler support)</div><div><br></div>Every C compiler comes with a definition of fabsf nowadays and we'll just use the native one.<br><div><div><div><div class="gmail_extra"><br></div><div class="gmail_extra">Nicolas<br><br></div><div class="gmail_extra"><div class="gmail_quote">2016-07-29 16:33 GMT+02:00 Henrik Johansen <span dir="ltr"><<a href="mailto:henrik.s.johansen@veloxit.no" target="_blank">henrik.s.johansen@veloxit.no</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br>It may be *in* 2003 onwards, but the generated code is positively abysmal, at least in 2015.<br>
<br>
*cough*<br>
float fabsf(float x) { return (float) fabs( (double)x ); }<br>
*cough*<br>
<br>
Couldn't even be inlined on full optimization settings in latest 2015 version I checked...<br>
(same goes for fminf, fmaxf, etc)<br>
<br>
Cheers,<br>
Henry<br>
<br></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> On 29 Jul 2016, at 2:40 , GitHub <<a href="mailto:noreply@github.com">noreply@github.com</a>> wrote:<br>
><br>
> Branch: refs/heads/Cog<br>
> Home: <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm</a><br>
> Commit: 88e24a3e92004f9590099482f53eaac3eccc3f20<br>
> <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/88e24a3e92004f9590099482f53eaac3eccc3f20" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/88e24a3e92004f9590099482f53eaac3eccc3f20</a><br>
> Author: Nicolas Cellier <<a href="mailto:nicolas.cellier@sirehna.com">nicolas.cellier@sirehna.com</a>><br>
> Date: 2016-07-29 (Fri, 29 Jul 2016)<br>
><br>
> Changed paths:<br>
> M platforms/win32/vm/sqPlatformSpecific.h<br>
> M platforms/win32/vm/sqWin32.h<br>
><br>
> Log Message:<br>
> -----------<br>
> Gather missing MSVC functions in sqPlatformSpecific.h<br>
><br>
> Reason: I added them to sqWin32.h but there were already some in sqPlatformSpecific.h<br>
> Note: fabsf is in MSVC at least from 2003 edition, and in gcc for even longer, so avoid redefining if we know it's useless<br>
><br>
><br>
> Commit: 3dadd587627048d3854c61c60ff231dc6f30627c<br>
> <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3dadd587627048d3854c61c60ff231dc6f30627c" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3dadd587627048d3854c61c60ff231dc6f30627c</a><br>
> Author: Nicolas Cellier <<a href="mailto:nicolas.cellier@sirehna.com">nicolas.cellier@sirehna.com</a>><br>
> Date: 2016-07-29 (Fri, 29 Jul 2016)<br>
><br>
> Changed paths:<br>
> M platforms/win32/vm/sqPlatformSpecific.h<br>
> M platforms/win32/vm/sqWin32Utils.c<br>
><br>
> Log Message:<br>
> -----------<br>
> Provide round implementation for older MSVC<br>
><br>
> round is available since MSVC 2013 (_MSC_VER >= 1800)<br>
><br>
><br>
> Commit: 9c44322e2469eef8d7c1bb57c7acd5a6795dfb1b<br>
> <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9c44322e2469eef8d7c1bb57c7acd5a6795dfb1b" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/9c44322e2469eef8d7c1bb57c7acd5a6795dfb1b</a><br>
> Author: Nicolas Cellier <<a href="mailto:nicolas.cellier@sirehna.com">nicolas.cellier@sirehna.com</a>><br>
> Date: 2016-07-29 (Fri, 29 Jul 2016)<br>
><br>
> Changed paths:<br>
> M build.win32x86/common/Makefile<br>
> M build.win32x86/common/Makefile.plugin<br>
> M build.win64x64/common/Makefile<br>
> M build.win64x64/common/Makefile.plugin<br>
><br>
> Log Message:<br>
> -----------<br>
> Don't use the provided 3rd party DirectX include files<br>
><br>
> These files are provided by mingw.<br>
> Since we link with mingw library, it's better to use mingw include.<br>
><br>
> There were Teleplace specific hacks justifying to put a local copy.<br>
> But these hacks are no longer necessary for building uptodate Squeak & al vm.<br>
> Note that provided 3rd party libraries (.lib) are for MSVC and are provided for 32bits only.<br>
><br>
><br>
> Compare: <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/77b30368c1e8...9c44322e2469" rel="noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/77b30368c1e8...9c44322e2469</a><br>
<br>
<br></blockquote></div><br></div></div></div></div></div>