<div dir="ltr"><div><div><div><div><div><div><div><div><div><div><div>Hi Ben,<br></div>I don't know...<br></div>The original issue was failing builds in LLP64 branch (like <a href="https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/150687436">https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/150687436</a>).<br></div>Build were failing because vmCallback.h uses sqIntptr_t.<br></div>Since this file is only used in *abicc.c, it's enough to just invert the order of include files so that sqIntptr_t is already defined.<br></div><br></div>What about ppc?<br></div>- it does not include vmCallback.h (are callback suppported on ppc?)<br></div>- there is no ppc automated build set on travis/appveyor<br></div>- I can't test it myself<br><br></div>So I don't think there's an LLP64 related issue.<br></div>The issue is more about the fact that ppc support will be roting fast in those conditions.<br></div><div class="gmail_extra"><br><div class="gmail_quote">2016-08-09 1:39 GMT+02:00 Ben Coman <span dir="ltr"><<a href="mailto:btc@openinworld.com" target="_blank">btc@openinworld.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
On Tue, Aug 9, 2016 at 4:52 AM, GitHub <<a href="mailto:noreply@github.com">noreply@github.com</a>> wrote:<br>
> Log Message:<br>
> -----------<br>
> Authorize usage of Squeak types in vmCallback<br>
><br>
> For example, vmCallback might rely on sqIntptr_t for LLP64 compatibility.<br>
> The order of include files must be revised in order to do so<br>
> This change has been applied to ia32abicc.c cf. <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/336c3d5ba394eb2812db7cee5320ce8c03f6112c" rel="noreferrer" target="_blank">https://github.com/<wbr>OpenSmalltalk/opensmalltalk-<wbr>vm/commit/<wbr>336c3d5ba394eb2812db7cee5320ce<wbr>8c03f6112c</a> (336c3d5)<br>
<br>
> It must also be applied to other supported ABI (arm32, x64)<br>
> Note sure what is needed for ppc32abicc...<br>
<br>
For those platforms you don't get to straight away, could you open an<br>
Issue on github to track?<br>
cheers -ben<br>
</blockquote></div><br></div>