<div dir="ltr">><span style="font-size:13px">compiled with the toolchain for XCode 7.2.</span><div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">So how are you doing the compile? </span></div><div><span style="font-size:13px"><br></span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 16, 2016 at 3:13 PM, Yoshiki Ohshima <span dir="ltr"><<a href="mailto:Yoshiki.Ohshima@acm.org" target="_blank">Yoshiki.Ohshima@acm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Great!<br>
<br>
The crash happens with the 32-bit VM shipped in the 5.1 all in one. I<br>
can reproduce it the latest code of opensmalltalk-vm on github, and<br>
compiled with the toolchain for XCode 7.2.1.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
On Fri, Sep 16, 2016 at 3:04 PM, John McIntosh<br>
<<a href="mailto:johnmci@smalltalkconsulting.com">johnmci@smalltalkconsulting.<wbr>com</a>> wrote:<br>
><br>
> Ok, we'll I"m not sure which version of the source code is being compiled here, or how this is being done (Xcode project, cmd line script?)<br>
><br>
> First If the VM is compiled for 32bit it uses NON-ARC memory management, if it is compiled for 64bit then it should be ARC aware.<br>
><br>
> The returnAndRemoveOldest is from the ancient Apple Queue.m/h which is ill named and returns for ARC a retain count of one, which then requires the RELEASEOBJ.<br>
><br>
><br>
> - (void) ioGetNextEvent: (sqInputEvent *) evt {<br>
><br>
> ioProcessEvents();<br>
><br>
> id event = [eventQueue returnAndRemoveOldest];<br>
><br>
> if (event) {<br>
><br>
> @autoreleasepool {<br>
><br>
> [self processAsOldEventOrComplexEven<wbr>t: event placeIn: evt];<br>
><br>
> }<br>
><br>
> RELEASEOBJ(event);<br>
><br>
> }<br>
><br>
> }<br>
><br>
><br>
> The use of the autoreleasepool here is for the iOS platform where a more complex procedure occurs to return data from the touch data. For OSX it just drops the bytes (length sizeof(sqInputEvent))into the given sqInputEvent buffer for consumption by Smalltalk.<br>
><br>
><br>
> In general it just takes a possible object off the queue and pulls the data bytes into a C structure for consumption. Under non-ARC the object is retained within the Queue.m/h and has to be later released. I think I should take one of the more standard GCD queue examples and replace the older logic in the near future.<br>
><br>
><br>
> - (void ) processAsOldEventOrComplexEven<wbr>t: (id) event placeIn: (sqInputEvent *) evt {<br>
><br>
> if ([event[0] intValue] == 1) {<br>
><br>
> [(NSData *)event[1] getBytes: evt length: sizeof(sqInputEvent)];<br>
><br>
> if (evt->type == EventTypeKeyboard) {<br>
><br>
> // NSLog(@"keyboard pc %i cc %i uc %i m %i",((sqKeyboardEvent *)evt)->pressCode,((<wbr>sqKeyboardEvent *) evt)->charCode,((<wbr>sqKeyboardEvent *) evt)->utf32Code,((<wbr>sqKeyboardEvent *) evt)->modifiers);<br>
><br>
> }<br>
><br>
> return;<br>
><br>
> }<br>
><br>
> }<br>
><br>
><br>
> As for the crash. it appears when we are doing the self interpretedKeyEvents<br>
><br>
> -(void)keyDown:(NSEvent*)<wbr>theEvent {<br>
><br>
> keyBoardStrokeDetails *aKeyBoardStrokeDetails = AUTORELEASEOBJ([[<wbr>keyBoardStrokeDetails alloc] init]);<br>
><br>
> aKeyBoardStrokeDetails.keyCode = [theEvent keyCode];<br>
><br>
> aKeyBoardStrokeDetails.<wbr>modifierFlags = [theEvent modifierFlags];<br>
><br>
> NSArray *down = @[theEvent];<br>
><br>
> @synchronized(self) {<br>
><br>
> lastSeenKeyBoardStrokeDetails = aKeyBoardStrokeDetails;<br>
><br>
> [self interpretKeyEvents: down];<br>
><br>
> self.<wbr>lastSeenKeyBoardStrokeDetails = NULL;<br>
><br>
> }<br>
><br>
> }<br>
><br>
><br>
><br>
> which triggers a failure via...<br>
><br>
>>> 6 org.squeak.Squeak5.1.32.All-<wbr>in-One 0x00130512 getCrashDumpFilenameInto + 82<br>
>>> 7 com.apple.CoreFoundation 0x98c2ddaf _CFAutoreleasePoolPop + 47<br>
><br>
><br>
> On saturday I"ll see if I can recreate it and see what might be causing it, mind nothing comes to mind at the moment.<br>
><br>
><br>
><br>
> On Fri, Sep 16, 2016 at 10:16 AM, Tobias Pape <<a href="mailto:Das.Linux@gmx.de">Das.Linux@gmx.de</a>> wrote:<br>
>><br>
>><br>
>><br>
>> On 16.09.2016, at 19:09, Yoshiki Ohshima <<a href="mailto:Yoshiki.Ohshima@acm.org">Yoshiki.Ohshima@acm.org</a>> wrote:<br>
>><br>
>> > On Fri, Sep 16, 2016 at 6:22 AM, Yoshiki Ohshima<br>
>> > <<a href="mailto:Yoshiki.Ohshima@acm.org">Yoshiki.Ohshima@acm.org</a>> wrote:<br>
>> >> Would it be a feasible approach to try to use XCode (clang) Analyze?<br>
>> ><br>
>> > I got 9 errors from clang-checker. One of those that looks most<br>
>> > suspicious is this one attached:<br>
>> ><br>
>> > Apparently just commenting the RELEASEOBJ line is not the right<br>
>> > thing... But does anybody has some ideas?<br>
>><br>
>> Somewhere a RETAINOBJECT might be missing?<br>
>><br>
>> Best regards<br>
>> -Tobias<br>
>><br>
>> ><br>
>> > --<br>
>> > -- Yoshiki<br>
>> > <event.png><br>
>><br>
><br>
><br>
><br>
> --<br>
> ==============================<wbr>==============================<wbr>===============<br>
> John M. McIntosh. Corporate Smalltalk Consulting Ltd <a href="https://www.linkedin.com/in/smalltalk" rel="noreferrer" target="_blank">https://www.linkedin.com/in/<wbr>smalltalk</a><br>
> ==============================<wbr>==============================<wbr>===============<br>
><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
-- Yoshiki<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">===========================================================================<br>John M. McIntosh. Corporate Smalltalk Consulting Ltd <a href="https://www.linkedin.com/in/smalltalk" target="_blank">https://www.linkedin.com/in/smalltalk</a><br>===========================================================================<br></div></div></div></div>
</div>