<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2016-11-01 3:10 GMT+01:00 Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank">nicolas.cellier.aka.nice@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2016-11-01 2:06 GMT+01:00 Eliot Miranda <span dir="ltr"><<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br><div dir="ltr">Hi Nicolas,<div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Mon, Oct 31, 2016 at 3:38 PM, Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank">nicolas.cellier.aka.nice@gmai<wbr>l.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2016-10-31 22:42 GMT+01:00 <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Eliot Miranda uploaded a new version of VMMaker to project VM Maker:<br>
<a href="http://source.squeak.org/VMMaker/VMMaker.oscog-eem.1972.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/VMMak<wbr>er/VMMaker.oscog-eem.1972.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: VMMaker.oscog-eem.1972<br>
Author: eem<br>
Time: 31 October 2016, 2:42:12.362675 pm<br>
UUID: 0e6a54ad-d62f-4b69-9f0d-7b66f8<wbr>350984<br>
Ancestors: VMMaker.oscog-eem.1971<br>
<br>
Redo fixing extB sign extension in NewsqueakV4 & SistaV1 extPushIntegerBytecode & extUnconditionalJump in interpreter and Cogit using bitShift: 8 instead of << 8. Slang seems to generate the correct code with bitAShift:, but not with <<.<br>
<br></blockquote><div><br></div><div>Hi Eliot,<br></div><div>it would have worked if you would have used bitOr: instead of +<br>I'd say bitOr: better fits the intention:<br></div><div>you want to assemble the bits, you do not really want to perform arithmetic here.<br></div></div></div></div></blockquote><div><br></div></span><div>OK, but in 2's complement they do the same thing, so + sdeems just as good for me.</div><div> </div></div></div></div></blockquote><div>Not when we mix negative with positive obviously...<br></div></div></div></div></blockquote><div><br></div><div>Ah, my bad, I see it now: you only change sign of first extB byte, then all successive extB remain positive.<br></div><div>In this case yes, you can use + like bitOr:, you don't need my blessing obviously :) <br></div></div></div></div>