<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Hi Esteban,<br><br></div><div><br>On May 4, 2017, at 12:08 PM, Esteban Lorenzano <<a href="mailto:estebanlm@gmail.com">estebanlm@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><span></span></div></blockquote><blockquote type="cite"><div><meta http-equiv="Content-Type" content="text/html charset=utf-8"><br class=""><div><blockquote type="cite" class=""><div class="">On 4 May 2017, at 16:48, Tobias Pape <<a href="mailto:Das.Linux@gmx.de" class="">Das.Linux@gmx.de</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">On 04.05.2017, at 16:37, Esteban Lorenzano <<a href="mailto:estebanlm@gmail.com" class="">estebanlm@gmail.com</a>> wrote:<br class=""><br class=""><br class=""><br class=""><blockquote type="cite" class="">On 4 May 2017, at 16:36, Tobias Pape <<a href="mailto:Das.Linux@gmx.de" class="">Das.Linux@gmx.de</a>> wrote:<br class=""><br class=""><br class=""><br class=""><blockquote type="cite" class="">On 04.05.2017, at 16:33, Esteban Lorenzano <<a href="mailto:estebanlm@gmail.com" class="">estebanlm@gmail.com</a>> wrote:<br class=""><br class="">B3D plugin is still broken for me :(<br class=""></blockquote><br class="">win32?<br class="">Well, I just made it compile, to be frank.<br class="">Maybe we should disable again for the time being?<br class=""></blockquote><br class="">no, for macOS.<span class="Apple-converted-space"> </span><br class="">I just pulled latest changes from osvm into pharo and… boom!<br class=""><br class=""></blockquote><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Well… I haven't touched this… eliot?</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div><div>I got it. B3D plugin Makefile asumes it will be building a bundle while Pharo does not use them. </div><div>I need to rewrite it as this: </div><div><br class=""></div><div><div># The current version of B3DAcceleratorPlugin (the OpenGL interface) uses</div><div># FindWindow, GetWindowGreatestAreaDevice & GetWindowPort which are Carbon &</div><div># 32-bit only. So include the Carbon frameworks. Until this can be rewritten</div><div># this implies no 64-bit OpenGL on Mac OS X :-(.</div><div><br class=""></div><div>INCDIRS:=../../platforms/Cross/plugins/FilePlugin \</div><div> ../../platforms/unix/vm</div><div>INCDIRS:=../../platforms/unix/vm</div><div><br class=""></div><div><br class=""></div><div>ifeq ($(VM),Pharo)</div><div>EXTRALIBSFLAGS:=-undefined dynamic_lookup</div><div>else</div><div># These three are imported from the VM. Use this explicit list instead of</div><div># -undefined dynamic_lookup to get errors for any other missing imports.</div><div>EXTRABFLAGS=-Wl,-bundle_loader,$(VMDIR)/$(VM)</div><div>EXTRADYFLAGS=-Wl,-bundle_loader,$(VMDIR)/$(VM)</div><div>endif </div><div>EXTRALIBS:=$(EXTRALIBSFLAGS) -framework CoreFoundation -framework Carbon -framework OpenGL -framework AGL</div><div><br class=""></div><div>include ../common/Makefile.plugin</div><div class=""><br class=""></div><div class="">(yes, we need the -undefined flag :( )</div><div class=""><br class=""></div><div class="">I will be submitting the fix tomorrow.</div></div></div></div></blockquote><div><br></div>Let's talk this over. Please don't change this. I'm working on getting the Squeak bundle to work. I now have it compiling and loading and a bit more (runs without error only in gdb's because at full speed it trips over itself; but there is still no visible output). <div><br></div><div>If you want to fix the Pharo build in the short term simply remove B3DAcceleratorPlugin from plugins.ext. I expect that the correct fix will be to change Makefile.plugin so that it respects the values set in the <span style="background-color: rgba(255, 255, 255, 0);">B3DAcceleratorPlugin/Makefile when building a Pharo-style dylib plugin. </span><br><div><br><div><blockquote type="cite"><div><div><div><div class=""><br class=""></div><div class="">Esteban</div></div><br class=""><blockquote type="cite" class=""><div class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Best regards</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span class="Apple-tab-span" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px;"> </span><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">-Tobias</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">Esteban<br class=""><br class=""><blockquote type="cite" class=""><br class="">Best regards<br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>-Tobias<br class=""><br class=""><blockquote type="cite" class=""><br class=""><br class=""><blockquote type="cite" class="">On 3 May 2017, at 19:08, Tobias Pape <<a href="mailto:Das.Linux@gmx.de" class="">Das.Linux@gmx.de</a>> wrote:<br class=""><br class=""><br class=""><br class=""><blockquote type="cite" class="">On 03.05.2017, at 17:51, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com" class="">eliot.miranda@gmail.com</a>> wrote:<br class=""><br class=""><br class="">Hi Tobias,<br class=""><br class="">first, apologies.<br class=""><br class=""></blockquote><br class="">No need.<br class=""><br class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class="">On May 3, 2017, at 8:17 AM, Tobias Pape <<a href="mailto:Das.Linux@gmx.de" class="">Das.Linux@gmx.de</a>> wrote:<br class=""><br class=""><br class="">Dear all<br class=""><br class="">a small summary of some latest issues.<br class=""><br class="">1. With the pulling of the Pharo sources (see PR #55), there was one unguarded change that messed up ctrl-... keystrokes for Squeak. Since the input event handling in Pharo is now completely different from Squeak's, this change probably makes sense for Pharo.<span class="Apple-converted-space"> </span><br class="">Hence, I guarded the change[1] to Pharo only.<br class=""><br class="">2. I put that into the repo. Meanwhile, Eliot has worked on B3D.<br class="">This changes broke the build for windows. Yes, this was also mentioned in a commit comment[2].<br class="">However, since this work looks decidedly in-progress and not-windows-centered (which is totally fine), I would have recommended to put such work in a dedicated branch.<br class="">This could have been done via<br class=""><br class="">$ git checkout -b eliot-B3D-fixes Cog<br class=""><br class="">and then committing and pushing to this branch<br class="">(commit would still be `git commit` or `scripts/gitci` for that matter,<span class="Apple-converted-space"> </span><br class="">push would be `git push origin eliot-B3D-fixes`)<br class=""><br class="">That way, all the changes and the (decidedly) broken parts would have been isolated to that branch.<br class=""></blockquote><br class="">I promise not to do this again. I have to practice the branching to make it a habit.<br class=""></blockquote><br class="">Yeah, I can understand. I also still need to practice for that habit. I<br class=""><br class=""><blockquote type="cite" class="">Some times I fool myself into thinking that I can get away with a fee commits because I'm in the timezone I'm in. Must stop doing this ;-)<br class=""><br class=""></blockquote><br class="">;) Well, Just see If I'm on Skype or so and ask away, sometimes it could just work.<br class=""><br class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class=""><br class="">Since I needed a working windows VM with the fixes for (1.), I have gone forward and<br class=""><br class="">3. I added back the logging stuff for B3D/DirectX[3]. Eliot, I hope this is matches your intentions?<br class=""></blockquote><br class="">The intent is to have one copy of the logging code in<br class=""><br class="">platforms/Cross/plugins/B3DPluginAccelerator/sqOpenGLRenderer.c/.h, not several copies in every platform. Let's please make the win32 platform work like this too.<br class=""></blockquote><br class="">It wont do. Because we have a separate Direct3D renderer that does not include the .h or link to the .c file.<br class="">By default, the win32 build operates in dual-mode where the OpenGL/Direct3D-selection is made at runtime, but can also operate completely without OpenGL. In this case, none of that stuff would be there…<br class="">(That's why the verbosity-flag had not gl attached before, I presume)<br class="">It's now done in a way that tries to use the sqOpenGLRenderer debugging stuff if present, else provides its own.<br class="">Does that make sense?<br class=""><br class="">Best regards<br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>-Tobias<br class=""><br class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class=""><br class="">4. Eliot's B3D Debugging code relies on getImageName which is defined in sq.h. Yet it seems to have always been missing on Win32?<span class="Apple-converted-space"> </span><br class="">I added it hence[4].<br class=""><br class="">Best regards<br class="">-Tobias<br class=""><br class=""><br class="">[1]: <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d1f88876025e437eaeb480658cd72b2112dff7aa" class="">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d1f88876025e437eaeb480658cd72b2112dff7aa</a><br class="">[2]: <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c94ebce7b49e657839c0923ba52d801ba5101826" class="">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c94ebce7b49e657839c0923ba52d801ba5101826</a><br class="">[3]: <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/e23c5aaae39540e7dc32e240f820f8cd433955be" class="">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/e23c5aaae39540e7dc32e240f820f8cd433955be</a><br class="">[4]: <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/aa9503fd8c372b38c086d2daf7d3d2cf9e0453be" class="">https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/aa9503fd8c372b38c086d2daf7d3d2cf9e0453be</a></blockquote></blockquote></blockquote></blockquote></blockquote></blockquote></div></blockquote></div><br class=""></div></blockquote></div></div></div></body></html>