<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div><span></span></div><div><meta http-equiv="content-type" content="text/html; charset=utf-8"><div>Hi Javier,</div><div><br>On Feb 2, 2018, at 11:50 AM, Javier Pimas <<a href="mailto:notifications@github.com">notifications@github.com</a>> wrote:<br><br></div><blockquote type="cite"><div><span></span></div></blockquote><blockquote type="cite"><p>As this is a submodule, .git is not a directory but a file. Changing the line</p>
<pre><code>if [ -d `dirname $0`/../.git ]; then
</code></pre>
<p>to</p>
<pre><code>if [ -e `dirname $0`/../.git ]; then
</code></pre>
<p>makes the script work, but as I have no idea what this script does, I'm not sure if the change is correct</p>
<div itemscope="" itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope="" itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362688331">
<meta itemprop="name" content="View Issue">
</div>
<meta itemprop="description" content="View this Issue on GitHub">
</div>
<script type="application/json" data-scope="inboxmarkup"><div x-apple-mail="AppleTemporaryPresentationElement" style="display: none;">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@melkyades in #209: As this is a submodule, .git is not a directory but a file. Changing the line\r\n\r\n if [ -d `dirname $0`/../.git ]; then\r\n\r\nto \r\n\r\n if [ -e `dirname $0`/../.git ]; then\r\n\r\nmakes the script work, but as I have no idea what this script does, I'm not sure if the change is correct"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/209#issuecomment-362688331"}}}</div></script></blockquote><div><br></div>The <span style="background-color: rgba(255, 255, 255, 0);">platforms/Cross/vm/sqSCCSVersion.h file is supposed to contain the information that identifies a particular commit. It stands for Source Code Control System Version. With many SCCS systems, including Subversion, which was used to manage the source before git, one can use a metalanguage in the source file that is recognized and replaced by commit information on each commit. Git doesn't support this (?!?!?!). So we have to do it manually with this script. The script gets run automatically by the commit script scripts/gitci, but if you do a fresh check out you'll need to run the script to get the VM's --version command to print meaningful commit information.</span></div><div><br></div><div>Ideally we would have rewritten the makefiles to do this automatically but not yet :-)</div><div><br></div><div>Anyway, your fix looks correct. Please feel free to commit. Also you might copy my opening paragraph above ("<span style="background-color: rgba(255, 255, 255, 0);">The platforms ... meaningful commit information.") as a comment at the start of the script.</span></div><div><br></div><div>Sorry for the mess. But most importantly, welcome!!! It's great to see you and Guido involved. I'm very excited. Thank you!<br><br><div><span style="background-color: rgba(255, 255, 255, 0);"><br>Eliot _,,,^..^,,,_ (phone)</span></div></div></body></html>