<div dir="ltr">Could you check this version?<div><br></div><div><a href="https://github.com/marianopeck/OSSubprocess/pull/30">https://github.com/marianopeck/OSSubprocess/pull/30</a></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 26, 2018 at 10:19 AM, Guillermo Polito <span dir="ltr"><<a href="mailto:guillermopolito@gmail.com" target="_blank">guillermopolito@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'll try making a PR now to fix that.</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 26, 2018 at 10:19 AM, Guillermo Polito <span dir="ltr"><<a href="mailto:guillermopolito@gmail.com" target="_blank">guillermopolito@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hmm, wait, I think these are two different issues :)<div><br></div><div>I managed to successfully use OSSubprocess in 64bits with some tweaks. The problem is that OSSubprocess does some manual type coertions like assumming 32 bits:</div><div><br></div><div><div>collectArgumentPointersInto: aPointer</div><div>    [...]</div><div>    aPointer nbUInt32AtOffset: (self argVArguments size - 1) * self systemAccessor sizeOfPointer put: 0<br></div></div><div><br></div><div>That should probably be replaced by:</div><div><br></div><div>    aPointer platformUnsignedLongAt: (self argVArguments size - 1) * self systemAccessor sizeOfPointer put: 0.<br></div><div><br></div><div><br></div><div>Now, those methods depend on UFFI, having UFFI is a must for OSSubprocess.</div></div><div class="gmail_extra"><div><div class="m_6952638181545843727h5"><br><div class="gmail_quote">On Thu, Feb 22, 2018 at 7:07 PM, Alistair Grant <span dir="ltr"><<a href="mailto:akgrant0710@gmail.com" target="_blank">akgrant0710@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Hi Eliot,<br>
<br>
On 21 February 2018 at 18:56, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>> wrote:<br>
><br>
> Hi Alistair,<br>
<span>><br>
> On Wed, Feb 21, 2018 at 9:31 AM, Alistair Grant <<a href="mailto:akgrant0710@gmail.com" target="_blank">akgrant0710@gmail.com</a>> wrote:<br>
>><br>
>> Yep, OSSubprocess doesn't work on 64 bit VMs at the moment.<br>
>><br>
>> Eliot, Mariano has indicated he's waiting on<br>
>> <a href="https://github.com/pharo-project/pharo-vm/pull/142" rel="noreferrer" target="_blank">https://github.com/pharo-proje<wbr>ct/pharo-vm/pull/142</a><br>
>> Do you know of a reason why it shouldn't be merged?<br>
><br>
><br>
</span>> Well, the changes to FilePlugin.class belong in VMMaker.oscog.<br>
<br>
Good point.  I'm embarrassed to say I didn't look at the code, just<br>
the comments.<br>
<br>
<br>
>  And cfileRecordSize doesn't make sense , since all pointers are of the same size in C:<br>
><br>
> cfileRecordSize<br>
> + "Return the size of a stdio FILE* handle"<br>
> + <option: #PharoVM><br>
> + <static: false><br>
> + ^self sizeof: #'FILE*'<br>
><br>
> I would simple use (self sizeof: #'void *') or (self sizeof: #'FILE *').<br>
<br>
Yep - although this could use <inline: #always>.<br>
<br>
<br>
> Other than that I can't see any problems.<br>
<br>
I've sent Mariano a message asking him to clarify what he needs from<br>
this PR.  I'll follow up again after he replies (I'm keen to see<br>
OSSubprocess on the 64 bit VM).<br>
<br>
Thanks!<br>
Alistair<br>
<div class="m_6952638181545843727m_9124170365356904749HOEnZb"><div class="m_6952638181545843727m_9124170365356904749h5"><br>
<br>
>><br>
>> Thanks,<br>
>> Alistair<br>
>><br>
>><br>
>><br>
>> On 21 February 2018 at 18:22, phideaux <<a href="mailto:jcasler@cdix.org" target="_blank">jcasler@cdix.org</a>> wrote:<br>
>> > When trying the simple example (ls -la /Users) in Pharo 6.1 64bit you get a<br>
>> > talkback because<br>
>> > ExternalAddress integerAt:put:size:signed: fails using<br>
>> > 'primitiveFFIIntegerAtPut' in module 'SqueakFFIPrims'<br>
>> ><br>
>> > Something to do with OSSubprocess not accommodating 64 bit pointers perhaps?<br>
>> ><br>
>> > Same code works fine on 32bit version.<br>
>> ><br>
>> > VM is CoInterpreter VMMaker.oscog-eem.2254 Jul 20 2017 for macOS downloaded<br>
>> > from <a href="http://pharo.org/downloaded" rel="noreferrer" target="_blank">pharo.org/downloaded</a> page<br>
>> ><br>
>> > Regards,<br>
>> > Jay+<br>
>> ><br>
>> ><br>
>> ><br>
>> > --<br>
>> > Sent from: <a href="http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html" rel="noreferrer" target="_blank">http://forum.world.st/Pharo-Sm<wbr>alltalk-Developers-f1294837.ht<wbr>ml</a><br>
>> ><br>
>><br>
><br>
><br>
><br>
</div></div><span class="m_6952638181545843727m_9124170365356904749HOEnZb"><font color="#888888">> --<br>
> _,,,^..^,,,_<br>
> best, Eliot<br>
><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div></div></div>-- <br><div class="m_6952638181545843727m_9124170365356904749gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><table cellspacing="0" cellpadding="0" style="border-collapse:collapse">
<tbody>
<tr>
<td valign="top" style="width:86.0px;height:84.0px;border-style:solid;border-width:0.0px 1.0px 0.0px 0.0px;border-color:transparent #000000 transparent transparent;padding:4.0px 4.0px 4.0px 4.0px">
<p style="margin:0.0px 0.0px 0.0px 0.0px;min-height:14.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)"> </font><span style="font-family:Helvetica;font-size:10px"> </span><span style="font-family:Helvetica;font-size:10px"> </span><img src="https://www.cristal.univ-lille.fr//videos/presentation.jpg" width="200" height="112"><img src="https://intranet.cnrs.fr/Cnrs_pratique/communiquer/guides/PublishingImages/CNRS-filaire-Bichro-CMJN.jpg" alt="" style="font-size:12.8px;margin:5px" width="96" height="96"></p>















</td><td valign="top" style="width:378.0px;height:84.0px;border-style:solid;border-width:0.0px 0.0px 0.0px 1.0px;border-color:transparent transparent transparent #000000;padding:4.0px 4.0px 4.0px 4.0px"><p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)">Guille Polito</font></p><p style="margin:0.0px 0.0px 0.0px 0.0px"><span style="color:rgb(0,0,0);font-family:Helvetica;font-size:10px">Research Engineer</span></p><p style="margin:0px;font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0);min-height:10px"><font></font></p><p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)">Centre de Recherche en Informatique, Signal et Automatique de Lille</font></p><p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)">CRIStAL - UMR 9189</font></p>
<p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)">French National Center for Scientific Research - <font><u><a href="http://www.cnrs.fr" target="_blank">http://www.cnrs.fr</a></u></font></font></p><p style="margin:0px;font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0);min-height:10px"><br></p>
<p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)"><b>Web:</b> <a href="http://guillep.github.io" target="_blank"><font><u>http://guillep.github.io</u></font></a></font></p>
<p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)"><b>Phone: </b><a href="tel:+33%206%2052%2070%2066%2013" value="+33652706613" target="_blank">+33 06 52 70 66 13</a></font></p>
</td>
</tr>
</tbody>
</table></div></div></div></div>
</div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_6952638181545843727gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><table cellspacing="0" cellpadding="0" style="border-collapse:collapse">
<tbody>
<tr>
<td valign="top" style="width:86.0px;height:84.0px;border-style:solid;border-width:0.0px 1.0px 0.0px 0.0px;border-color:transparent #000000 transparent transparent;padding:4.0px 4.0px 4.0px 4.0px">
<p style="margin:0.0px 0.0px 0.0px 0.0px;min-height:14.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)"> </font><span style="font-family:Helvetica;font-size:10px"> </span><span style="font-family:Helvetica;font-size:10px"> </span><img src="https://www.cristal.univ-lille.fr//videos/presentation.jpg" width="200" height="112"><img src="https://intranet.cnrs.fr/Cnrs_pratique/communiquer/guides/PublishingImages/CNRS-filaire-Bichro-CMJN.jpg" alt="" style="font-size:12.8px;margin:5px" width="96" height="96"></p>















</td><td valign="top" style="width:378.0px;height:84.0px;border-style:solid;border-width:0.0px 0.0px 0.0px 1.0px;border-color:transparent transparent transparent #000000;padding:4.0px 4.0px 4.0px 4.0px"><p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)">Guille Polito</font></p><p style="margin:0.0px 0.0px 0.0px 0.0px"><span style="color:rgb(0,0,0);font-family:Helvetica;font-size:10px">Research Engineer</span></p><p style="margin:0px;font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0);min-height:10px"><font></font></p><p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)">Centre de Recherche en Informatique, Signal et Automatique de Lille</font></p><p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)">CRIStAL - UMR 9189</font></p>
<p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)">French National Center for Scientific Research - <font><u><a href="http://www.cnrs.fr" target="_blank">http://www.cnrs.fr</a></u></font></font></p><p style="margin:0px;font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0);min-height:10px"><br></p>
<p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)"><b>Web:</b> <a href="http://guillep.github.io" target="_blank"><font><u>http://guillep.github.io</u></font></a></font></p>
<p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)"><b>Phone: </b><a href="tel:+33%206%2052%2070%2066%2013" value="+33652706613" target="_blank">+33 06 52 70 66 13</a></font></p>
</td>
</tr>
</tbody>
</table></div></div></div></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><table cellspacing="0" cellpadding="0" style="border-collapse:collapse">
<tbody>
<tr>
<td valign="top" style="width:86.0px;height:84.0px;border-style:solid;border-width:0.0px 1.0px 0.0px 0.0px;border-color:transparent #000000 transparent transparent;padding:4.0px 4.0px 4.0px 4.0px">
<p style="margin:0.0px 0.0px 0.0px 0.0px;min-height:14.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)"> </font><span style="font-family:Helvetica;font-size:10px"> </span><span style="font-family:Helvetica;font-size:10px"> </span><img src="https://www.cristal.univ-lille.fr//videos/presentation.jpg" width="200" height="112"><img src="https://intranet.cnrs.fr/Cnrs_pratique/communiquer/guides/PublishingImages/CNRS-filaire-Bichro-CMJN.jpg" alt="" style="font-size:12.8px;margin:5px" width="96" height="96"></p>















</td><td valign="top" style="width:378.0px;height:84.0px;border-style:solid;border-width:0.0px 0.0px 0.0px 1.0px;border-color:transparent transparent transparent #000000;padding:4.0px 4.0px 4.0px 4.0px"><p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)">Guille Polito</font></p><p style="margin:0.0px 0.0px 0.0px 0.0px"><span style="color:rgb(0,0,0);font-family:Helvetica;font-size:10px">Research Engineer</span></p><p style="margin:0px;font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0);min-height:10px"><font></font></p><p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)">Centre de Recherche en Informatique, Signal et Automatique de Lille</font></p><p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)">CRIStAL - UMR 9189</font></p>
<p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)">French National Center for Scientific Research - <font><u><a href="http://www.cnrs.fr" target="_blank">http://www.cnrs.fr</a></u></font></font></p><p style="margin:0px;font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0);min-height:10px"><br></p>
<p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)"><b>Web:</b> <a href="http://guillep.github.io" target="_blank"><font><u>http://guillep.github.io</u></font></a></font></p>
<p style="margin:0.0px 0.0px 0.0px 0.0px"><font face="Helvetica" color="#000000" style="font-stretch:normal;font-size:10px;line-height:normal;font-family:Helvetica;color:rgb(0,0,0)"><b>Phone: </b>+33 06 52 70 66 13</font></p>
</td>
</tr>
</tbody>
</table></div></div></div></div>
</div>