<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Hi Javier,</div><div id="AppleMailSignature"><br></div><div id="AppleMailSignature"> are you sure your sources are up to date? Do you have a special version of sqVirtualMachine.h? What happens if you do a clean checkout of opensmalltalk/vm and try and build that? To me it looks like you may have imported your own modifications and hit the merge wrong because you've not included some new plugin support.</div><div id="AppleMailSignature"><br></div><div id="AppleMailSignature">Let me recommend that <span style="background-color: rgba(255, 255, 255, 0);">you do a clean checkout and build of opensmalltalk/vm (in a separate directory, as a reference). If that doesn't build then we have problems. If it does build then you'll be able to compare your modified version and hence have a good chance of finding and fixing the issue.</span><br><br><span style="background-color: rgba(255, 255, 255, 0);">_,,,^..^,,,_ (phone)</span></div><div><br>On Mar 31, 2018, at 7:09 PM, Javier Pimás <<a href="mailto:elpochodelagente@gmail.com">elpochodelagente@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><span></span></div></blockquote><blockquote type="cite"><div><div dir="ltr">And I have a similar problem with LargeIntegerPlugin<div><br></div><div><div><font face="monospace, monospace">../../src/plugins/LargeIntegers/LargeIntegers.c:169:36: error: expected ‘)’ before ‘objectPointer’</font></div><div><font face="monospace, monospace"> extern sqInt isIntegerObject(sqInt objectPointer);</font></div><div><font face="monospace, monospace"> ^</font></div><div><font face="monospace, monospace">../../src/plugins/LargeIntegers/LargeIntegers.c:105:33: note: in definition of macro ‘isIntegerObject’</font></div><div><font face="monospace, monospace"> # define isIntegerObject(oop) ((oop) & 1)</font></div><div> </div></div><div><br></div><div><div><font face="monospace, monospace">$ git diff HEAD~2 ../../src/plugins/LargeIntegers/LargeIntegers.c</font></div><div><font face="monospace, monospace">diff --git a/src/plugins/LargeIntegers/LargeIntegers.c b/src/plugins/LargeIntegers/LargeIntegers.c</font></div><div><font face="monospace, monospace">index 267a96d2c..638ca631f 100644</font></div><div><font face="monospace, monospace">--- a/src/plugins/LargeIntegers/LargeIntegers.c</font></div><div><font face="monospace, monospace">+++ b/src/plugins/LargeIntegers/LargeIntegers.c</font></div><div><font face="monospace, monospace">@@ -102,8 +102,7 @@ static const int andOpIndex = 0;</font></div><div><font face="monospace, monospace"> </font></div><div><font face="monospace, monospace"> #if defined(SQUEAK_BUILTIN_PLUGIN)</font></div><div><font face="monospace, monospace"> </font></div><div><font face="monospace, monospace" color="#cc0000">-//sqInt isIntegerObject(sqInt oop) { return oop & 1; }</font></div><div><font face="monospace, monospace" color="#cc0000">-//# define isIntegerObject(oop) ((oop) & 1)</font></div><div><font face="monospace, monospace" color="#38761d">+# define isIntegerObject(oop) ((oop) & 1)</font></div><div><font face="monospace, monospace"> </font></div></div><div>where does this C code difference come from?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Mar 31, 2018 at 6:48 PM, Javier Pimás <span dir="ltr"><<a href="mailto:elpochodelagente@gmail.com" target="_blank">elpochodelagente@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>when generating the squeakffi plugin I get different sources than the ones in src/plugins dir. Mine generate a compiler error, because isImmediate is redefined, any idea?</div><div><br></div><div>the original src/X64SysVFFIPlugin.c contains (~ line 460):</div><div><br></div><div>#if !defined(isImmediate)</div><div>#if VM_PROXY_MAJOR > 1 || (VM_PROXY_MAJOR == 1 && VM_PROXY_MINOR >= 13)</div><div>extern sqInt isImmediate(sqInt anObject);</div><div>#else</div><div># define isImmediate(anObject) 0</div><div>#endif</div><div>#endif</div><div><br></div><div><br></div><div>while mine gets:</div><div><br></div><div><div>#if VM_PROXY_MAJOR > 1 || (VM_PROXY_MAJOR == 1 && VM_PROXY_MINOR >= 13)</div><div>extern sqInt isImmediate(sqInt anObject);</div><div>#else</div><div># define isImmediate(anObject) 0</div><div>#endif</div><div>#if !defined(isImmediate)</div><div>#endif</div></div><div><br></div><div><br></div><div>Cheers,</div><div>Pocho</div><span class="HOEnZb"><font color="#888888"><div><br></div>-- <br><div class="m_-4366700481788527041gmail_signature"><div dir="ltr">Javier Pimás<br>Ciudad de Buenos Aires</div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Javier Pimás<br>Ciudad de Buenos Aires</div></div>
</div>
</div></blockquote></body></html>