Hi Alistair,<br>
<br>
> On Apr 3, 2018, at 4:19 AM, akgrant43 <notifications@github.com> wrote:<br>
> <br>
> Hi Nicolas,<br>
> <br>
> Thanks. I agree that this isn't simplifying the existing code, although I also think it isn't really adding complexity. It does result in an arguably correct response where before it was clearly incorrect.<br>
> <br>
> Just for the record, the same incorrect behaviour currently exists in Squeak (#atEnd returns the wrong result for a non-regular file).<br>
> <br>
<br>
Please add the gist of David's description of feof() to the code when you fix this.  That's extremely important information.  TIA<br>
> Cheers,<br>
> Alistair<br>
> <br>
> —<br>
> You are receiving this because you are subscribed to this thread.<br>
> Reply to this email directly, view it on GitHub, or mute the thread.<br>
> <br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/232#issuecomment-378252881">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW9IipNb1EAr3ab9k9-kAe52YrMA2ks5tk3tEgaJpZM4S6rMa">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyWx3Dghn65F_gzTIRFoNND945YWZ5ks5tk3tEgaJpZM4S6rMa.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/232#issuecomment-378252881"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eliotmiranda in #232: Hi Alistair,\n\n\u003e On Apr 3, 2018, at 4:19 AM, akgrant43 \u003cnotifications@github.com\u003e wrote:\n\u003e \n\u003e Hi Nicolas,\n\u003e \n\u003e Thanks. I agree that this isn't simplifying the existing code, although I also think it isn't really adding complexity. It does result in an arguably correct response where before it was clearly incorrect.\n\u003e \n\u003e Just for the record, the same incorrect behaviour currently exists in Squeak (#atEnd returns the wrong result for a non-regular file).\n\u003e \n\nPlease add the gist of David's description of feof() to the code when you fix this.  That's extremely important information.  TIA\n\u003e Cheers,\n\u003e Alistair\n\u003e \n\u003e —\n\u003e You are receiving this because you are subscribed to this thread.\n\u003e Reply to this email directly, view it on GitHub, or mute the thread.\n\u003e \n"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/232#issuecomment-378252881"}}}</script>