<p>sqFileAtEnd() hasn't done any error checking.  However adding it has<br>
caused a report of primitive failures where previously none occurred.<br>
No information is given about what the error is (errno isn't set), and<br>
because no other functions are doing error checking we can't know how<br>
far back the error occurred.<br>
We can't limit error checking to this call because clearerr() clears not<br>
only the error flag, but also the end-of-file flag.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>sqFileAtEnd() revert to previous error checking</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245/files#diff-0">platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c</a>
    (36)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245.patch'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245.patch</a></li>
  <li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245.diff'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW2ZyZaplHI1rvGpFpFYQfp0kpLNuks5tm5Z8gaJpZM4TM5uU">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW99I-3PIgYIm0woL_e4d-JtuC3AEks5tm5Z8gaJpZM4TM5uU.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"sqFileAtEnd() revert to previous error checking (#245)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/245"}}}</script>