<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 13, 2018 at 5:23 PM, Eliot Miranda <span dir="ltr"><<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Vincent,<br> I've replied to the vm-dev list (Open Smalltalk Virtual Machine Development Discussion <<a href="mailto:vm-dev@lists.squeakfoundation.org" target="_blank">vm-dev@lists.<wbr>squeakfoundation.org</a>>). For some reason your post went to <a href="mailto:vm-dev-bounces@lists.squeakfoundation.org" target="_blank">vm-dev-bounces@lists.<wbr>squeakfoundation.org</a>.<br><div><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Fri, Apr 13, 2018 at 4:45 PM, <span dir="ltr"><<a href="mailto:Vincent.Blondeau@lamresearch.com" target="_blank">Vincent.Blondeau@lamresearch.<wbr>com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div class="m_5256968582070099177gmail-m_-6824569385127352209gmail-m_-5061407663236514738WordSection1">
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">Hi,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">In the way to change dynamically the icon of the main window, I am adding a primitive in the HostWindow VM Plugin.
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">So, I implemented the primitive call on Pharo side:
<a href="https://github.com/pharo-project/pharo/pull/1198" target="_blank">https://github.com/pharo-proje<wbr>ct/pharo/pull/1198</a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">Modified the C plugin file:
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/248" target="_blank">https://github.com/OpenSmallta<wbr>lk/opensmalltalk-vm/pull/248</a> (only the windows version for now)</span></p></div></div></blockquote><div><br></div></span><div>Be careful. Unless you add stub definitions to unix and iOS files you may end up breaking the build. Have you tested the build on iOS and a linux?</div></div></div></div></div></blockquote><div><br></div><div>I looked. You did the right thing (of course). Forgive me!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div class="gmail_extra"><div class="gmail_quote"><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div lang="EN-US"><div class="m_5256968582070099177gmail-m_-6824569385127352209gmail-m_-5061407663236514738WordSection1"><p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">And implemented the binding in VMMaker, and I would commit this last one.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif">However, I do not have the write access to
</span><a href="http://source.squeak.org/VMMaker" title="static listing url" target="_blank">http://source.squeak.org/VMMak<wbr>er</a>. Could someone grant me to it?</p></div></div></blockquote><div><br></div></span><div>+1. I'd like Vincent to be a committer.</div><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div lang="EN-US"><div class="m_5256968582070099177gmail-m_-6824569385127352209gmail-m_-5061407663236514738WordSection1"><p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Thanks in advance,<u></u><u></u></p>
<p class="MsoNormal">Vincent<span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></span></p>
<div>
<div style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb(225,225,225);padding:3pt 0in 0in">
<p class="MsoNormal" style="margin-left:0.5in"><b><span style="font-size:11pt;font-family:Calibri,sans-serif">From:</span></b><span style="font-size:11pt;font-family:Calibri,sans-serif"> Blondeau, Vincent
<br>
<b>Sent:</b> Tuesday, February 6, 2018 18:36<span class="m_5256968582070099177gmail-m_-6824569385127352209gmail-"><br>
<b>To:</b> Pharo Development List <<a href="mailto:pharo-dev@lists.pharo.org" target="_blank">pharo-dev@lists.pharo.org</a>><br>
</span><b>Subject:</b> RE: [Pharo-dev] Change Pharo window icon<u></u><u></u></span></p>
</div>
</div><div><div class="m_5256968582070099177gmail-m_-6824569385127352209gmail-h5">
<p class="MsoNormal" style="margin-left:0.5in"><u></u> <u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"><span style="font-size:11pt;font-family:Calibri,sans-serif">Hi,<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:0.5in"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></span></p>
<p class="MsoNormal" style="margin-left:1in">The fact that he mentioned an ability to change window's title from inside of the running image suggested me that he actually wants to change an icon at runtime too.<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:0.5in"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></span></p>
<p class="MsoNormal" style="margin-left:0.5in"><span style="font-size:11pt;font-family:Calibri,sans-serif">Indeed, that is what I would like to do.<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:0.5in"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></span></p>
<p class="MsoNormal" style="margin-left:0.5in"><span style="font-size:11pt;font-family:Calibri,sans-serif">Cheers,<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:0.5in"><span style="font-size:11pt;font-family:Calibri,sans-serif">Vincent<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:0.5in"><span style="font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></span></p>
<p class="MsoNormal" style="margin-left:1in"><b><span style="font-size:11pt;font-family:Calibri,sans-serif">From:</span></b><span style="font-size:11pt;font-family:Calibri,sans-serif"> Pharo-dev [</span><a href="mailto:pharo-dev-bounces@lists.pharo.org" target="_blank"><span style="font-size:11pt;font-family:Calibri,sans-serif">mailto:pharo-dev-bounces@list<wbr>s.pharo.org</span></a><span style="font-size:11pt;font-family:Calibri,sans-serif">]
<b>On Behalf Of </b>Aliaksei Syrel<br>
<b>Sent:</b> Saturday, February 3, 2018 8:09<br>
<b>To:</b> Pharo Development List <</span><a href="mailto:pharo-dev@lists.pharo.org" target="_blank"><span style="font-size:11pt;font-family:Calibri,sans-serif">pharo-dev@lists.pharo.org</span></a><span style="font-size:11pt;font-family:Calibri,sans-serif">><br>
<b>Subject:</b> Re: [Pharo-dev] Change Pharo window icon<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:1in"><u></u> <u></u></p>
<div>
<p class="MsoNormal" style="margin-left:1in">Hi Eliot,<u></u><u></u></p>
<div>
<p class="MsoNormal" style="margin-left:1in"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1in">I thought Vincent wants to change Pharo main window icon (image).<u></u><u></u></p>
<blockquote style="border-style:none none none solid;border-left-width:1pt;border-left-color:rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<p class="MsoNormal" style="margin-left:1in"><span style="font-size:9.5pt;font-family:Arial,sans-serif;color:rgb(34,34,34);background-color:white">I would like to know how to change the main Pharo window icon.</span><u></u><u></u></p>
</blockquote>
<div>
<p class="MsoNormal" style="margin-left:1in"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1in">The fact that he mentioned an ability to change window's title from inside of the running image suggested me that he actually wants to change an icon at runtime too.<u></u><u></u></p>
</div>
<blockquote style="border-style:none none none solid;border-left-width:1pt;border-left-color:rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<p class="MsoNormal" style="margin-left:1in"><span style="font-size:9.5pt;font-family:Arial,sans-serif;color:rgb(34,34,34);background-color:white">DisplayScreen class >> primitiveWindowTitle:string:</span><u></u><u></u></p>
</blockquote>
<div>
<p class="MsoNormal" style="margin-left:1in"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1in">I may be wrong :) But in any case it would be nice to be able to change window icon from the image.<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal" style="margin-left:1in"><br clear="all">
<u></u><u></u></p>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<p class="MsoNormal" style="margin-left:1in">Cheers,<u></u><u></u></p>
<div>
<p class="MsoNormal" style="margin-left:1in">Alex<u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<p class="MsoNormal" style="margin-left:1in"><u></u> <u></u></p>
<div>
<p class="MsoNormal" style="margin-left:1in">On 3 February 2018 at 17:01, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border-style:none none none solid;border-left-width:1pt;border-left-color:rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<div>
<div>
<p class="MsoNormal" style="margin-right:0in;margin-bottom:12pt;margin-left:1in">
Hi Aliaksei,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-right:0in;margin-bottom:12pt;margin-left:1in">
On Feb 3, 2018, at 4:30 AM, Aliaksei Syrel <<a href="mailto:alex.syrel@gmail.com" target="_blank">alex.syrel@gmail.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="margin-top:5pt;margin-bottom:5pt">
<div>
<div>
<p class="MsoNormal" style="margin-left:1in">Hi<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1in"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1in">Since Pharo uses sdl2 (or should use)<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1in"><a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__wiki.libsdl.org_SDL-5FSetWindowIcon&d=DwMFaQ&c=RWI7EqL8K9lqtga8KxgfzvOYoob76EZWE0yAO85PVMQ&r=kIZIYXBAA3fhM7P5HOuTC5w6mnEApTfXPTq3lR34ZiY&m=l_zmsWuiNTZnwaqnFoVWP5ND2EpDg5f0AKqxxWuemDc&s=BquvgGPDy_24-w_Ilvxs0hadxiqEJ341IaRCJSoJPNM&e=" target="_blank">https://wiki.libsdl.org/SDL_Se<wbr>tWindowIcon</a><u></u><u></u></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal" style="margin-left:1in"><u></u> <u></u></p>
</div>
<p class="MsoNormal" style="margin-left:1in">Hang on. Changing a window's icon is not at all the same as changing the VM's icon. Which are we talking about here? I thought we were talking about changing the VM icon.<u></u><u></u></p>
<div>
<div>
<div>
<p class="MsoNormal" style="margin-right:0in;margin-bottom:12pt;margin-left:1in">
<u></u> <u></u></p>
<blockquote style="margin-top:5pt;margin-bottom:5pt">
<div>
<div>
<p class="MsoNormal" style="margin-left:1in"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1in">Alex<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:1in"><u></u> <u></u></p>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal" style="margin-left:1in"><u></u> <u></u></p>
</div>
</div>
</div></div></div>
</div>
</blockquote></div></div></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="m_5256968582070099177gmail-m_-6824569385127352209gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</font></span></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</div></div>