<p>When marshalling integer values, the value is first extracted from the Smalltalk oop via the method <code>ffiIntegerValueOf:</code> .</p>
<ul>
<li>SmallInteger -> SmallInteger value (signed value on 31 or 61 bits on 32bits and 64bits VM)</li>
<li>false/true -> 0/1</li>
<li>nil -> 0</li>
<li>Character -> Character value (may be more than 8 bits long!)</li>
<li>LargePositiveInteger -> 32bits positive integer value (or fail) (or 64 bits if ThreadedFFIPlugin)</li>
<li>LargeNegativeInteger -> 32bits signed integer value (or fail) (or 64bits if ThreadedFFIPlugin)</li>
</ul>
<p>Then the value is cast to the expected value in <code>ffiArgByValue:</code> which will have the effect of silently masking potential errors...<br>
(<code>1<<31</code> could be passed to a signed int and re-interpreted as <code>-(1<<31)</code> for example).</p>
<p>IMO we could enforce bound checks and raise an Error...<br>
We should at least do this in the debug version if ever there is a concern about speed (but I don't think so).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/251">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW0vzC-qAbYUDuLh0Jg1aL7wI1b9Sks5tpu1WgaJpZM4TZkRD">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW68F-CqdrJFtJHBHfyL9Bdq8Dh6Wks5tpu1WgaJpZM4TZkRD.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/251"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"There is no bound check when marshalling FFI atomic integer arguments (#251)"}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/251"}}}</script>