<p>Hi Vincent,  shouldn't all the<br>
files[0].isStdioStream = sqIsFileDescriptorATTY(0);<br>
occurrences in platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c: sqFileStdioHandlesInto read either<br>
files[0].isStdioStream = sqIsFileDescriptorATTY(STD_INPUT_HANDLE);<br>
or<br>
files[0].isStdioStream = sqIsFileDescriptorATTY(files[0].file);<br>
?  Since sqIsFileDescriptorATTY could a HANDLE right?  And then you could get rid of the<br>
h = (HANDLE)_get_osfhandle(fdNum);<br>
call in sqIsFileDescriptorATTY</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/254#issuecomment-384105237">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW7FXfecsxkq3VMHWqUKi5e7FZQS4ks5tr62BgaJpZM4Tg0qx">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyWz-S9-gRpsdpZxeTq9OxM49CW3mYks5tr62BgaJpZM4Tg0qx.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/254#issuecomment-384105237"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eliotmiranda in #254: Hi Vincent,  shouldn't all the\r\n    files[0].isStdioStream = sqIsFileDescriptorATTY(0);\r\noccurrences in platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c: sqFileStdioHandlesInto read either\r\n    files[0].isStdioStream = sqIsFileDescriptorATTY(STD_INPUT_HANDLE);\r\nor\r\n    files[0].isStdioStream = sqIsFileDescriptorATTY(files[0].file);\r\n?  Since sqIsFileDescriptorATTY could a HANDLE right?  And then you could get rid of the \r\n    h = (HANDLE)_get_osfhandle(fdNum);\r\ncall in sqIsFileDescriptorATTY"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/254#issuecomment-384105237"}}}</script>