<p><b>@akgrant43</b> commented on this pull request.</p>

<p>One minor fix for RiscOS and this is good to go (I'll update the code for Unix after this has been integrated).</p><hr>

<p>In <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/254#discussion_r187681590">platforms/RiscOS/plugins/FilePlugin/sqFilePluginBasicPrims.c</a>:</p>
<pre style='color:#555'>> @@ -407,6 +407,11 @@ sqInt sqFileStdioHandlesInto(SQFile files[3]) {
        return 0;
 }
 
+sqInt sqFileDescriptorType(int fdNum) {
+       //Not implemented
+       return 0;
</pre>
<p>RiscOS should return -1 (error), not 0 (no console).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/254#pullrequestreview-119517188">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyWyldmsTzuMorwSTOpaiCA8vm9pjZks5txcwSgaJpZM4Tg0qx">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW-taAjg-5UzxXYmg4MNPjRZqq4OKks5txcwSgaJpZM4Tg0qx.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/254#pullrequestreview-119517188"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 commented on #254"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/254#pullrequestreview-119517188"}}}</script>
<script type="application/ld+json">{"@type":"MessageCard","@context":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"@akgrant43 commented on 254","sections":[{"text":"One minor fix for RiscOS and this is good to go (I'll update the code for Unix after this has been integrated).","activityTitle":"**akgrant43**","activityImage":"https://avatars1.githubusercontent.com/u/2062166?s=160\u0026v=4","activitySubtitle":"@akgrant43","facts":[]}],"potentialAction":[{"targets":[{"os":"default","uri":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/254#pullrequestreview-119517188"}],"@type":"OpenUri","name":"View on GitHub"},{"name":"Unsubscribe","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"MuteNotification\",\"threadId\":327371441}"}],"themeColor":"26292E"}</script>