<blockquote>
<p>why merge and roll back later? I mean, why is this just a temporary fix? What are the disadvantages/advantages if we keep the commit?</p>
</blockquote>
<p>The advantage is that the script will survive Travis not updating the environment for us.</p>
<p>The disadvantages are:</p>
<ul>
<li>It's a bit slower (there's obviously more being done).</li>
<li>It increases slightly the chances that a temporary network problem will causes the build to fail.</li>
</ul>
<p>Of course, there may be others that I haven't thought of.</p>
<p>I should also add that it isn't 100% clear to me that Travis will ever "fix" the issue.  They may decide that if you want to install software you should do an update - they mention trying to automatically determine whether an install is done, and maybe our script isn't detected.</p>
<p>Cheers,<br>
Alistair</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/261#issuecomment-389312917">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW4FUCXEKfj8ULUy08ZL28Zg3HtQEks5ty0LhgaJpZM4T_vBU">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW8_8yLKwtxrxRvFkBY8Wbk_aRGYQks5ty0LhgaJpZM4T_vBU.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/261#issuecomment-389312917"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #261: \u003e why merge and roll back later? I mean, why is this just a temporary fix? What are the disadvantages/advantages if we keep the commit?\r\n\r\nThe advantage is that the script will survive Travis not updating the environment for us.\r\n\r\nThe disadvantages are:\r\n\r\n- It's a bit slower (there's obviously more being done).\r\n- It increases slightly the chances that a temporary network problem will causes the build to fail.\r\n\r\nOf course, there may be others that I haven't thought of.\r\n\r\nI should also add that it isn't 100% clear to me that Travis will ever \"fix\" the issue.  They may decide that if you want to install software you should do an update - they mention trying to automatically determine whether an install is done, and maybe our script isn't detected.\r\n\r\nCheers,\r\nAlistair"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/261#issuecomment-389312917"}}}</script>
<script type="application/ld+json">{"@type":"MessageCard","@context":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"Re: [OpenSmalltalk/opensmalltalk-vm] .travis_install.sh update (#261)","sections":[{"text":"","activityTitle":"**akgrant43**","activityImage":"https://avatars1.githubusercontent.com/u/2062166?s=160\u0026v=4","activitySubtitle":"@akgrant43","facts":[]}],"potentialAction":[{"name":"Add a comment","@type":"ActionCard","inputs":[{"isMultiLine":true,"@type":"TextInput","id":"IssueComment","isRequired":false}],"actions":[{"name":"Comment","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"IssueComment\",\"repositoryFullName\":\"OpenSmalltalk/opensmalltalk-vm\",\"issueId\":261,\"IssueComment\":\"{{IssueComment.value}}\"}"}]},{"name":"Close pull request","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"PullRequestClose\",\"repositoryFullName\":\"OpenSmalltalk/opensmalltalk-vm\",\"pullRequestId\":261}"},{"targets":[{"os":"default","uri":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/261#issuecomment-389312917"}],"@type":"OpenUri","name":"View on GitHub"},{"name":"Unsubscribe","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"MuteNotification\",\"threadId\":335474772}"}],"themeColor":"26292E"}</script>