<p>Closing.  It's obsolete.  There have been a few JIT bugs with shallowCopy and Spur that were fixed a while ago.  e.g. VMMaker.oscog-eem.1538<br>
Author: eem<br>
Time: 1 December 2015, 11:21:52.981 pm<br>
UUID: 8eb28260-86bc-4f74-b62d-aab8212d9272<br>
Ancestors: VMMaker.oscog-rmacnak.1537</p>
<p>Cogit:<br>
Fix /horrible/ bug with primitive error codes and fixups.  The adjustment of the initialPC to skip the primitive and error code, if any, was done after generating fixups for backward branches, and hence these branches were bogus.  Object>>shallowCopy in Spur is subject to this, but amazingly enough it has not surfaced before now.  Fix this by adjusting the initialPC before scanMethod scans for fixups.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/272#issuecomment-404595807">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyWwyv6u-zbYKdfsjebQ-EOx7ZPLVQks5uF4zkgaJpZM4VM4ie">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyWzlVkdEwTw1VV2GO6E0YabrlFU-Mks5uF4zkgaJpZM4VM4ie.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eliotmiranda in #272: Closing.  It's obsolete.  There have been a few JIT bugs with shallowCopy and Spur that were fixed a while ago.  e.g. VMMaker.oscog-eem.1538\r\nAuthor: eem\r\nTime: 1 December 2015, 11:21:52.981 pm\r\nUUID: 8eb28260-86bc-4f74-b62d-aab8212d9272\r\nAncestors: VMMaker.oscog-rmacnak.1537\r\n\r\nCogit:\r\nFix /horrible/ bug with primitive error codes and fixups.  The adjustment of the initialPC to skip the primitive and error code, if any, was done after generating fixups for backward branches, and hence these branches were bogus.  Object\u003e\u003eshallowCopy in Spur is subject to this, but amazingly enough it has not surfaced before now.  Fix this by adjusting the initialPC before scanMethod scans for fixups."}],"action":{"name":"View Issue","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/272#issuecomment-404595807"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/272#issuecomment-404595807",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/272#issuecomment-404595807",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [OpenSmalltalk/opensmalltalk-vm] ByteString(Object)\u003eshallowCopy segfaults (#272)",
"sections": [
{
"text": "",
"activityTitle": "**Eliot Miranda**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@eliotmiranda",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 272,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/272#issuecomment-404595807"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 355698846\n}"
}
],
"themeColor": "26292E"
}
]</script>