<p>…not available</p>
<p>According to the comment for primitiveFileStdioHandles():</p>
<p>Answer an Array of file handles for standard in, standard out and<br>
standard error, with nil in entries that are unvailable, e.g. because<br>
the platform does not provide standard error, etc.</p>
<p>However, on Windows in practice an array of sqFile entries with null<br>
handles is returned. The image is unable to distinguish between valid<br>
and invalid entries since sqFile is private to the VM.</p>
<ul>
<li>Modify sqWin32FilePrims.c() to set the valid mask correctly.</li>
<li>Modify primitiveFileStdioHandles() to treat a mask of 0 as<br>
successfully determining that no stdio is available (a normal case<br>
on Windows).<br>
A validMask of -1 is treated as an error.</li>
<li>Update comments to reflect changed behaviour</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>274 primitiveFileStdioHandles() fails to return nil if stdio file is not available</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276/files#diff-0">platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276/files#diff-1">platforms/RiscOS/plugins/FilePlugin/sqFilePluginBasicPrims.c</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276/files#diff-2">platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c</a>
    (31)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276/files#diff-3">src/plugins/FilePlugin/FilePlugin.c</a>
    (28)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276.patch'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276.patch</a></li>
  <li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276.diff'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW2XIR0F9cMpi3EirLhvEc66DyLGZks5uP72agaJpZM4V5aiz">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW4XCWOONc-VMl0xrITNg26-XKamNks5uP72agaJpZM4V5aiz.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"274 primitiveFileStdioHandles() fails to return nil if stdio file is … (#276)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "274 primitiveFileStdioHandles() fails to return nil if stdio file is … (#276)",
"sections": [
{
"text": "",
"activityTitle": "**akgrant43**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@akgrant43",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "2f91655",
"value": "274 primitiveFileStdioHandles() fails to return nil if stdio file is not available"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276/files#diff-0) (12 changes)"
},
{
"name": "Modified",
"value": "[platforms/RiscOS/plugins/FilePlugin/sqFilePluginBasicPrims.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276/files#diff-1) (11 changes)"
},
{
"name": "Modified",
"value": "[platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276/files#diff-2) (31 changes)"
},
{
"name": "Modified",
"value": "[src/plugins/FilePlugin/FilePlugin.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276/files#diff-3) (28 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 276,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 276\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/276.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 367372467\n}"
}
],
"themeColor": "26292E"
}
]</script>