<p>Hi Fabio,</p>
<p>I think using a CI environment variable to control the output of<br>
warnings is less than ideal:</p>
<ul>
<li>
<p>It is doing double duty with a variable, which is never a good idea.</p>
</li>
<li>
<p>If I'm running a CI that does allow rtprio and I want the warning, I<br>
have to write the non-obvious script to unset the environment<br>
variable.</p>
</li>
<li>
<p>If I'm running some other production environment and want to suppress<br>
the warning I have to do something like:</p>
</li>
</ul>
<p>export CI "this is a ugly hack to make smalltalk suppress one warning"<br>
squeak/pharo some.image</p>
<p>Either of:</p>
<p>--suppress-rtprio-warning  # previously suggested</p>
<p>or</p>
<p>--suppress list,of,warnings</p>
<p>as command line options is a better approach.  We have CI specific<br>
scripts which can do the appropriate thing.</p>
<p>Cheers,<br>
Alistair</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/279#issuecomment-414133977">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW9Mb04H34DD3z0GkYieWevL04WyVks5uSX9QgaJpZM4WC5lh">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW8TKC7gQ8P0RcWP0rl9YvwomJsOZks5uSX9QgaJpZM4WC5lh.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #279: Hi Fabio,\r\n\r\nI think using a CI environment variable to control the output of \r\nwarnings is less than ideal:\r\n\r\n- It is doing double duty with a variable, which is never a good idea.\r\n\r\n- If I'm running a CI that does allow rtprio and I want the warning, I \r\n  have to write the non-obvious script to unset the environment \r\n  variable.\r\n\r\n- If I'm running some other production environment and want to suppress \r\n  the warning I have to do something like:\r\n\r\nexport CI \"this is a ugly hack to make smalltalk suppress one warning\"\r\nsqueak/pharo some.image\r\n\r\nEither of:\r\n\r\n--suppress-rtprio-warning  # previously suggested\r\n\r\nor\r\n\r\n--suppress list,of,warnings\r\n\r\nas command line options is a better approach.  We have CI specific \r\nscripts which can do the appropriate thing.\r\n\r\n\r\nCheers,\r\nAlistair"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/279#issuecomment-414133977"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/279#issuecomment-414133977",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/279#issuecomment-414133977",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [OpenSmalltalk/opensmalltalk-vm] Suppress rtprio warning when ${CI} env var is set (#279)",
"sections": [
{
"text": "",
"activityTitle": "**akgrant43**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@akgrant43",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 279,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 279\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/279#issuecomment-414133977"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 369858913\n}"
}
],
"themeColor": "26292E"
}
]</script>