<div dir="auto"><div>Hi Ben,</div><div dir="auto"><br><br><br><div class="gmail_quote" dir="auto"><div dir="ltr">On Wed., 19 Sep. 2018, 16:50 Ben Coman, <<a href="mailto:btc@openinworld.com">btc@openinworld.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="ltr"><div dir="ltr"><div dir="ltr">Well spotted. But next puzzle...  Where do "those" numbers come from?  i.e...</div><div dir="ltr">Appveyor defines...    -DFILEVERSIONVALUES=2018,8,29,1622<div>My build defines...     -DFILEVERSIONVALUES=,,,</div></div></div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto">Yeah, sorry, I had to run for other things, but hoped it would provide enough of a clue.</div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote" dir="auto"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><br></div><div>Ahh, found it...</div><div><div>common/Makefile.tools:RCFLAGS:= --include-dir $(PLATDIR)/win32/misc -D_WIN32 -DFILEVERSIONVALUES=$(SVNMAJOR),$(SVNMINOR),$(SVNREV),$(SVNBUILD) '-DFILEVERSIONSTRING=\"$(SVNMAJOR).$(SVNMINOR).$(SVNREV).$(SVNBUILD)\\0\"'</div></div><div><br></div><div><br></div><div>Damn! Forgetting to run ```updateSCCSversions``` on a fresh clone bites me again! :( :(</div></div></div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto">I have a script that I always use to run the compilation. :-)  (I don't care about the overhead of repeatedly executing <span style="font-family:sans-serif">```updateSCCSversions``)</span></div><div dir="auto"><span style="font-family:sans-serif"><br></span></div><div dir="auto"><span style="font-family:sans-serif">Cheers,</span></div><div dir="auto"><span style="font-family:sans-serif">Alistair</span></div><div dir="auto"><span style="font-family:sans-serif"><br></span></div><div dir="auto"><span style="font-family:sans-serif"><br></span></div><div dir="auto"><span style="font-family:sans-serif"><br></span></div><div dir="auto"><span style="font-family:sans-serif"><br></span></div><div dir="auto"><div class="gmail_quote" dir="auto"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>Better now, thx Alistair.</div><div>cheers -ben</div><div><br><div class="gmail_quote"><div dir="ltr">On Wed, 19 Sep 2018 at 21:25, Alistair Grant <<a href="mailto:akgrant0710@gmail.com" target="_blank" rel="noreferrer">akgrant0710@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
Hi Ben,<br>
<br>
I've never built squeak.cog.spur on windows (or any other platform<br>
:-)), but if you look at the appveyor log you can see that<br>
FILEVERSIONVALUES being defined:<br>
<br>
<a href="https://ci.appveyor.com/project/OpenSmalltalk/vm/build/job/a6x5mg5uw7p8c882?fullLog=true" rel="noreferrer noreferrer" target="_blank">https://ci.appveyor.com/project/OpenSmalltalk/vm/build/job/a6x5mg5uw7p8c882?fullLog=true</a><br>
<br>
hth,<br>
Alistair<br>
<br>
On Wed, 19 Sep 2018 at 15:17, Ben Coman <<a href="mailto:btc@openinworld.com" target="_blank" rel="noreferrer">btc@openinworld.com</a>> wrote:<br>
><br>
><br>
> I tried to build via "build.win32x86/squeak.cog.spur/mvm" but got an error with the resource file...<br>
> ```<br>
> i686-w64-mingw32-windres \<br>
>     --include-dir ../../platforms/win32/misc \<br>
>     -D_WIN32 \<br>
>     -DFILEVERSIONVALUES=,,, '-DFILEVERSIONSTRING=\"...\\0\"'  \<br>
>     -i Squeak.rc \<br>
>     -o builddbg/vm/Squeak.res<br>
> ==><br>
> i686-w64-mingw32-windres: Squeak.rc:7: syntax error<br>
> make[1]: *** [../common/Makefile:296: Squeak.res] Error 1<br>
> ```<br>
><br>
> I see a reference at the top of [1] to this for Pharo but no direct resolution is mentioned.<br>
> [1] <a href="http://forum.world.st/Compiling-the-windows-32-bits-vm-td5072691.html" rel="noreferrer noreferrer" target="_blank">http://forum.world.st/Compiling-the-windows-32-bits-vm-td5072691.html</a><br>
><br>
> [Squeak.rc:7](<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/build.win32x86/squeak.cog.spur/Squeak.rc#L7" rel="noreferrer noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/build.win32x86/squeak.cog.spur/Squeak.rc#L7</a>) is...<br>
> ```<br>
> FILEVERSION FILEVERSIONVALUES<br>
> ```<br>
> and the value ",,," supplied for FILEVERSIONVALUES on the command line seems invalid.<br>
><br>
><br>
> I see Pharo has hardcoded the value...<br>
> <a href="https://www.diffchecker.com/O36vXV5b" rel="noreferrer noreferrer" target="_blank">https://www.diffchecker.com/O36vXV5b</a><br>
> <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/build.win32x86/pharo.cog.spur/Pharo.rc#L7" rel="noreferrer noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/build.win32x86/pharo.cog.spur/Pharo.rc#L7</a><br>
> ```<br>
>  FILEVERSION 5,0,0,0<br>
> ```<br>
><br>
> and if I do the same in Squeak.rc the build completes.<br>
> So should I submit a PR for that, or does anyone know how the command line "FILEVERSIONVALUES"<br>
> is supposed to be supplied a proper value?  Searching the repo doesn't give any hints...<br>
> <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/search?q=FILEVERSIONVALUES" rel="noreferrer noreferrer" target="_blank">https://github.com/OpenSmalltalk/opensmalltalk-vm/search?q=FILEVERSIONVALUES</a><br>
><br>
><br>
> cheers -ben<br>
</blockquote></div></div></div></div></div>
</blockquote></div></div></div>