<p><b>@eliotmiranda</b> commented on this pull request.</p>

<p>Hi Esteban,</p>
<pre><code>this looks good, but there is at least one remaining issue.  For example, the changes to platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c eliminate necessary "if (f->isStdioStream) Read/WriteConsole(..." variants.  Can you take a pass over platforms/win32/vm and roll back any incidental changes?
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#pullrequestreview-173116217">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW8SKqRQ4z8N7PEWiqfb2YWV9cGeWks5utHyUgaJpZM4X9365">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW5cRhGcFsUBve0jG6-p6s-k-BHxmks5utHyUgaJpZM4X9365.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eliotmiranda commented on #298"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#pullrequestreview-173116217"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#pullrequestreview-173116217",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#pullrequestreview-173116217",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@eliotmiranda commented on 298",
"sections": [
{
"text": "Hi Esteban,\r\n\r\n    this looks good, but there is at least one remaining issue.  For example, the changes to platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c eliminate necessary \"if (f-\u003eisStdioStream) Read/WriteConsole(...\" variants.  Can you take a pass over platforms/win32/vm and roll back any incidental changes?",
"activityTitle": "**Eliot Miranda**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@eliotmiranda",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#pullrequestreview-173116217"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}"
}
],
"themeColor": "26292E"
}
]</script>