<p>Hi Tom,</p>
<pre><code>not my area of expertise but I see from platforms/Cross/vm/sq.h this:
</code></pre>
<pre><code>/* User input recording II:
   The following functions and definition can be used on
   platform supporting events directly.
*/

/* Event types. */
#define EventTypeNone       0
#define EventTypeMouse      1
#define EventTypeKeyboard   2
#define EventTypeDragDropFiles  3
#define EventTypeMenu       4
#define EventTypeWindow     5
#define EventTypeComplex    6 /* For iPhone apps */
**#define EventTypeMouseWheel 7 /* defunct; platforms map to EventTypeKeyboard */**
#define EventTypePlugin     8 /* Terf: events from ActiveX Controls */
</code></pre>
<p>So what /is/ happening with genuine mouse wheel events?  Should we instead use e.g.</p>
<pre><code>#if DeliverMouseWheelEvents
... your code ...
#else
... existing code ...
#endif

or better still have some variable, settable via a primitive, etc, to enable delivery of mouse wheel events?  The mapping of wheel even to to key presses seems like a massive hack to me but images depending d on it, so if we do deliver them as proper events it means either (effectively) a new VM, or the VM providing a way to switch between the two variants.
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/303#issuecomment-437504831">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW99BuSMLRAlFVpNNCCQvaIMtmKj9ks5utfeFgaJpZM4YTr1T">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW8uFp3RCaSgCg1-ye1p3pdy7Pw3hks5utfeFgaJpZM4YTr1T.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eliotmiranda in #303: Hi Tom,\r\n\r\n    not my area of expertise but I see from platforms/Cross/vm/sq.h this:\r\n\r\n```\r\n/* User input recording II:\r\n   The following functions and definition can be used on\r\n   platform supporting events directly.\r\n*/\r\n\r\n/* Event types. */\r\n#define EventTypeNone       0\r\n#define EventTypeMouse      1\r\n#define EventTypeKeyboard   2\r\n#define EventTypeDragDropFiles  3\r\n#define EventTypeMenu       4\r\n#define EventTypeWindow     5\r\n#define EventTypeComplex    6 /* For iPhone apps */\r\n**#define EventTypeMouseWheel 7 /* defunct; platforms map to EventTypeKeyboard */**\r\n#define EventTypePlugin     8 /* Terf: events from ActiveX Controls */\r\n```\r\n\r\nSo what /is/ happening with genuine mouse wheel events?  Should we instead use e.g.\r\n\r\n```\r\n#if DeliverMouseWheelEvents\r\n... your code ...\r\n#else\r\n... existing code ...\r\n#endif\r\n\r\nor better still have some variable, settable via a primitive, etc, to enable delivery of mouse wheel events?  The mapping of wheel even to to key presses seems like a massive hack to me but images depending d on it, so if we do deliver them as proper events it means either (effectively) a new VM, or the VM providing a way to switch between the two variants."}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/303#issuecomment-437504831"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/303#issuecomment-437504831",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/303#issuecomment-437504831",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [OpenSmalltalk/opensmalltalk-vm] x11: emit mouse wheel events, drop the ctrl+arrow workaround (#303)",
"sections": [
{
"text": "",
"activityTitle": "**Eliot Miranda**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@eliotmiranda",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 303,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 303\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/303#issuecomment-437504831"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 407813459\n}"
}
],
"themeColor": "26292E"
}
]</script>