<p>Hi Esteban, Eliot & Ronie,</p>
<p>Ronie, thanks for the history and explanation re Unicode.</p>
<p>Esteban & Ronnie, can I ask what the long term goals are for this code base?</p>
<p>The reason is that it appears to be adding significant complexity to the code base:</p>
<p>It's breaking the existing directory structure, e.g. the two instances of sqUnixCharConv.c are in:</p>
<pre><code>./platforms/minheadless/unix/sqUnixCharConv.c
./platforms/unix/vm/sqUnixCharConv.c
</code></pre>
<p>It adds 69 file names.  Some of these obviously need to be duplicated, e.g. make files are specific to the build type, but other examples include:</p>
<ul>
<li>sqUnixCharConv.h is copied unchanged.</li>
<li>Changes the return types of some functions with the same name, e.g. 'int' to 'sqInt'.</li>
<li>sqWin32Heartbeat.c where the entire file is copied so that 1 function can be extended (ioHighResClock()).</li>
</ul>
<p>And with an admission of being too lazy to figure it out, I'm not sure how to build the Windows minheadless variant of, e.g., pharo.cog.spur.  There's:</p>
<pre><code>build.linux64x64/pharo.cog.spur.minheadless/build/mvm
</code></pre>
<p>for linux 64 bit, and the equivalent for linux 32 bit and MacOS 32 bit, but not MacOS 64 bit or Windows.  Should:</p>
<pre><code>build.minheadless.cmake/x86/pharo.cog.spur/mvm
</code></pre>
<p>be used?</p>
<p>I can understand the problems of chasing a moving target, but without a commitment to continue working on this it looks like it will increase technical debt.</p>
<p>Or am I missing something?</p>
<p>Thanks,<br>
Alistair</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440948727">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW2_Crjn95zhaU3RdCWAjoJGQCQK-ks5uxl5ggaJpZM4X9365">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW7LdjNg25XKhcHQU7eJeDcMrbNHrks5uxl5ggaJpZM4X9365.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #298: Hi Esteban, Eliot \u0026 Ronie,\r\n\r\nRonie, thanks for the history and explanation re Unicode.\r\n\r\nEsteban \u0026 Ronnie, can I ask what the long term goals are for this code base?\r\n\r\nThe reason is that it appears to be adding significant complexity to the code base:\r\n\r\nIt's breaking the existing directory structure, e.g. the two instances of sqUnixCharConv.c are in:\r\n\r\n```\r\n./platforms/minheadless/unix/sqUnixCharConv.c\r\n./platforms/unix/vm/sqUnixCharConv.c\r\n```\r\n\r\nIt adds 69 file names.  Some of these obviously need to be duplicated, e.g. make files are specific to the build type, but other examples include:\r\n\r\n- sqUnixCharConv.h is copied unchanged.\r\n- Changes the return types of some functions with the same name, e.g. 'int' to 'sqInt'.\r\n- sqWin32Heartbeat.c where the entire file is copied so that 1 function can be extended (ioHighResClock()).\r\n\r\nAnd with an admission of being too lazy to figure it out, I'm not sure how to build the Windows minheadless variant of, e.g., pharo.cog.spur.  There's:\r\n\r\n```\r\nbuild.linux64x64/pharo.cog.spur.minheadless/build/mvm\r\n```\r\n\r\nfor linux 64 bit, and the equivalent for linux 32 bit and MacOS 32 bit, but not MacOS 64 bit or Windows.  Should:\r\n\r\n```\r\nbuild.minheadless.cmake/x86/pharo.cog.spur/mvm\r\n```\r\n\r\nbe used?\r\n\r\nI can understand the problems of chasing a moving target, but without a commitment to continue working on this it looks like it will increase technical debt.\r\n\r\nOr am I missing something?\r\n\r\nThanks,\r\nAlistair\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440948727"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440948727",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440948727",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)",
"sections": [
{
"text": "",
"activityTitle": "**akgrant43**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@akgrant43",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 298,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 298\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-440948727"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}"
}
],
"themeColor": "26292E"
}
]</script>