<p>Current status:</p>
<ul>
<li>The CI build completes for:<br>
-- Windows<br>
-- Main Squeak and Pharo linux and Mac builds<br>
-- Other linux builds<br>
-- Other Mac builds fails in the newspeak tests.  I don't think this is<br>
related.</li>
</ul>
<p>I've only tested linux64 at this stage, but given:</p>
<ul>
<li>minheadless are (mostly) separate builds.</li>
<li>both Esteban and I have done some ad-hoc testing.</li>
<li>the CI succeeds.</li>
<li>the fact that this code is more susceptible than most to diverging<br>
from the main repository (due to code duplication).</li>
<li>Esteban and Doru both seem committed to continuing with this work.</li>
<li>integrating the code now will facilitate others looking at the code,<br>
e.g. Ben planned to have a look next week.</li>
</ul>
<p>it may be worthwhile integrating this now.</p>
<p>What do you think?</p>
<p>Just a reminder, the PR is not this one, but:</p>
<p><a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="383719073" data-permission-text="Issue title is private" data-url="https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/310" data-hovercard-type="pull_request" data-hovercard-url="/OpenSmalltalk/opensmalltalk-vm/pull/310/hovercard" href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/310">#310</a></p>
<p>My Win32 build fails trying to build and install freetype:</p>
<p>-- Installing: /home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/.thirdparty-cache/windows/i386/include/freetype2/freetype/tttables.h<br>
-- Installing: /home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/.thirdparty-cache/windows/i386/include/freetype2/freetype/tttags.h<br>
-- Installing: /home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/.thirdparty-cache/windows/i386/include/freetype2/ft2build.h<br>
CMake Error at cmake_install.cmake:35 (file):<br>
file INSTALL cannot find<br>
"/home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/build.win32x86/pharo.cog.spur/build/third-party/freetype-2.9.1/build/include/freetype/config/ftconfig.h".</p>
<p>I've never used cmake before, so am starting to learn about it, but does<br>
anyone recognise the above?</p>
<p>Cheers,<br>
Alistair</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441219345">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW5UXXO26C7aWMi4xo-5How-m15yVks5ux93ugaJpZM4X9365">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyWzbQQwcYiiYEZwytVYtYkxkFIJILks5ux93ugaJpZM4X9365.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akgrant43 in #298: Current status:\r\n\r\n- The CI build completes for:\r\n-- Windows\r\n-- Main Squeak and Pharo linux and Mac builds\r\n-- Other linux builds\r\n-- Other Mac builds fails in the newspeak tests.  I don't think this is \r\n   related.\r\n\r\nI've only tested linux64 at this stage, but given:\r\n\r\n- minheadless are (mostly) separate builds.\r\n- both Esteban and I have done some ad-hoc testing.\r\n- the CI succeeds.\r\n- the fact that this code is more susceptible than most to diverging \r\n  from the main repository (due to code duplication).\r\n- Esteban and Doru both seem committed to continuing with this work.\r\n- integrating the code now will facilitate others looking at the code, \r\n  e.g. Ben planned to have a look next week.\r\n\r\nit may be worthwhile integrating this now.\r\n\r\nWhat do you think?\r\n\r\nJust a reminder, the PR is not this one, but: \r\n\r\nhttps://github.com/OpenSmalltalk/opensmalltalk-vm/pull/310\r\n\r\n\r\nMy Win32 build fails trying to build and install freetype:\r\n\r\n\r\n-- Installing: /home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/.thirdparty-cache/windows/i386/include/freetype2/freetype/tttables.h\r\n-- Installing: /home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/.thirdparty-cache/windows/i386/include/freetype2/freetype/tttags.h\r\n-- Installing: /home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/.thirdparty-cache/windows/i386/include/freetype2/ft2build.h\r\nCMake Error at cmake_install.cmake:35 (file):\r\n  file INSTALL cannot find\r\n  \"/home/alistair/pharo7/pharo-snap/pharo-vm/opensmalltalk-vm/build.win32x86/pharo.cog.spur/build/third-party/freetype-2.9.1/build/include/freetype/config/ftconfig.h\".\r\n\r\n\r\nI've never used cmake before, so am starting to learn about it, but does \r\nanyone recognise the above?\r\n\r\n\r\nCheers,\r\nAlistair\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441219345"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441219345",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441219345",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [OpenSmalltalk/opensmalltalk-vm] Add minheadless vm (#298)",
"sections": [
{
"text": "",
"activityTitle": "**akgrant43**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@akgrant43",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 298,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 298\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/298#issuecomment-441219345"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402095801\n}"
}
],
"themeColor": "26292E"
}
]</script>