<p>Ronie submitted a pull request that fixes the build with cygwin for win32 ( <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="386385960" data-permission-text="Issue title is private" data-url="https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/311" data-hovercard-type="pull_request" data-hovercard-url="/OpenSmalltalk/opensmalltalk-vm/pull/311/hovercard" href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/311">#311</a> ) and I'm curious if any of my changes here are still applicable. <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1550655" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ronsaldo">@ronsaldo</a> could you comment on these...</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Fix function call declarations and return types (x64-msvc2017)</li>
<li>Fix unresolved external symbol 'alloca' (x64-msvc2017)</li>
<li>Workaround _controlfp() does not support _MCW_PC or _MCW_IC on x64. Expert review required.</li>
<li>Add architecture define _M_IX86 to ABI (x86-msvc2017)</li>
<li>Workaround hang allocating initial memory (x64-msvc2017). Expert review required.</li>
<li>Better 32bit CMakeLists.txt for SqueakFFIPrims (x86-msvc2017)</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-0">CMakeLists.txt</a>
(43)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-1">platforms/Cross/plugins/IA32ABI/ia32abicc.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-2">platforms/Cross/plugins/IA32ABI/x64win64abicc.c</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-3">platforms/Cross/plugins/IA32ABI/xabicc.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-4">platforms/minheadless/common/sqMain.c</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-5">platforms/minheadless/windows/sqPlatformSpecific-Win32.c</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-6">platforms/minheadless/windows/sqPlatformSpecific-Win32.h</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-7">platforms/minheadless/windows/sqWin32Main.c</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-8">platforms/minheadless/windows/sqWin32SpurAlloc.c</a>
(9)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312.patch'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312.patch</a></li>
<li><a href='https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312.diff'>https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AhLyW1g9niexwdw2fqn1e0hA76N-0s6Mks5u0fFogaJpZM4Y8rne">mute the thread</a>.<img src="https://github.com/notifications/beacon/AhLyW6kUUelokzi9oEGBSELwfOIOKc4Eks5u0fFogaJpZM4Y8rne.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/OpenSmalltalk/opensmalltalk-vm","title":"OpenSmalltalk/opensmalltalk-vm","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"DO NOT INTEGRATE - FOR DISCUSSION ONLY Minimalistic headless x64 msvc2017 (#312)"}],"action":{"name":"View Pull Request","url":"https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312",
"url": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "DO NOT INTEGRATE - FOR DISCUSSION ONLY Minimalistic headless x64 msvc2017 (#312)",
"sections": [
{
"text": "",
"activityTitle": "**Ben Coman**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@bencoman",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "a25b90f",
"value": "Fix function call declarations and return types (x64-msvc2017)"
},
{
"name": "530e788",
"value": "Fix unresolved external symbol 'alloca' (x64-msvc2017)"
},
{
"name": "291be23",
"value": "Workaround _controlfp() does not support _MCW_PC or _MCW_IC on x64. Expert review required."
},
{
"name": "8231b96",
"value": "Add architecture define _M_IX86 to ABI (x86-msvc2017)"
},
{
"name": "e58c5fd",
"value": "Workaround hang allocating initial memory (x64-msvc2017). Expert review required."
},
{
"name": "e37248f",
"value": "Better 32bit CMakeLists.txt for SqueakFFIPrims (x86-msvc2017)"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[CMakeLists.txt](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-0) (43 changes)"
},
{
"name": "Modified",
"value": "[platforms/Cross/plugins/IA32ABI/ia32abicc.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-1) (2 changes)"
},
{
"name": "Modified",
"value": "[platforms/Cross/plugins/IA32ABI/x64win64abicc.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-2) (3 changes)"
},
{
"name": "Modified",
"value": "[platforms/Cross/plugins/IA32ABI/xabicc.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-3) (2 changes)"
},
{
"name": "Modified",
"value": "[platforms/minheadless/common/sqMain.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-4) (1 changes)"
},
{
"name": "Modified",
"value": "[platforms/minheadless/windows/sqPlatformSpecific-Win32.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-5) (9 changes)"
},
{
"name": "Modified",
"value": "[platforms/minheadless/windows/sqPlatformSpecific-Win32.h](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-6) (2 changes)"
},
{
"name": "Modified",
"value": "[platforms/minheadless/windows/sqWin32Main.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-7) (1 changes)"
},
{
"name": "Modified",
"value": "[platforms/minheadless/windows/sqWin32SpurAlloc.c](https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312/files#diff-8) (9 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"issueId\": 312,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"OpenSmalltalk/opensmalltalk-vm\",\n\"pullRequestId\": 312\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 418560478\n}"
}
],
"themeColor": "26292E"
}
]</script>